[Ffmpeg-devel-irc] ffmpeg-devel.log.20130804

[burek]

[01:26] <cone-795> ffmpeg.git 03Michael Niedermayer 07master:f1873909070d: doc/examples/filtering_audio: make const arrays also static
[01:26] <cone-795> ffmpeg.git 03Michael Niedermayer 07master:8862ed73403a: avdevice/dshow: make constant arrays static
[01:26] <cone-795> ffmpeg.git 03Michael Niedermayer 07master:c0ef5d6c169f: avdevice/vfwcap: make constant arrays static
[01:27] <cone-795> ffmpeg.git 03Michael Niedermayer 07master:61af627d56c7: avfilter/graphparser: remove 256 char limit from create_filter()
[09:11] <ubitux> wm4: sorry, gonna resurect an old discussion (2 wks ago), about the YUVJ vs YUV+colorrange, my concern was indeed about the format negociation: some filters could be working on YUVJ only (let's say some DVD video specific processing), or YUV only (code assuming full range all the time)
[09:11] <ubitux> so to me it doesn't look wrong to have different pixel formats
[09:12] <ubitux> (yes i'm quickly backlogging the few weeks i missed...)
[13:34] <cone-878> ffmpeg.git 03Michael Niedermayer 07master:48188a512068: MAINTAINERS: order libavutil entries alphabetically
[13:34] <cone-878> ffmpeg.git 03Timothy Gu 07master:3415058541a4: vf_scale: add force_original_aspect_ratio
[13:37] <wm4> ubitux: but that would mean you have to add range variants for each pixel formats in theory
[13:37] <wm4> and someone else already thought this was a bad idea in the past (which is why the jpeg formats are deprecated)
[13:41] <cone-878> ffmpeg.git 03Andrey Utkin 07master:27cc3e72f850: doc/muxers: Document use case of mpegts muxer option tables_version
[13:43] <ubitux> wm4: kinda, but does it make any sense in practice?
[13:43] <ubitux> i mean can you have that much J variants?
[13:47] <ubitux> but anyway, it's not like i'm against removing the J variants; it's just that there might be a few things to consider before doing so, including this concern
[14:08] <cone-878> ffmpeg.git 03Nedeljko Babic 07master:18d7074b4e5a: libavcodec: Implementation of 32 bit fixed point FFT
[18:04] <ubitux> https://people.xiph.org/~xiphmont/demo/daala/demo2.shtml
[20:42] <wm4> where does it say that the buffer passed to avio_alloc_context() must be allocated with av_malloc?
[20:59] <nevcairiel>  * @param buffer Memory block for input/output operations via AVIOContext.
[20:59] <nevcairiel>  *        The buffer must be allocated with av_malloc() and friends.
[20:59] <nevcairiel> right in the comment?
[20:59] <nevcairiel> :)
[21:00] <wm4> somehow I overlooked that
[21:02] <wm4> this isn't new though
[21:02] <wm4> the commit from 2 years ago which added this says "Else a later buffer resize in ffio_set_buf_size() will ABORT."
[21:03] <wm4> never had it resize on me, though...
[21:03] <nevcairiel> not sure under which conditions that happens
[21:04] <wm4> mplayer traditionally makes the buffer 32K for some reason, maybe that's large enough
[21:06] <Compnn> wm4 : did you look at coverity ?
[21:06] <Compnn> i mean do you have an account to look at the mplayer review ther e?
[21:06] <wm4> Compnn: no
[22:50] <cone-882> ffmpeg.git 03Michael Niedermayer 07master:62cf5c114a38: avformat/matroskadec: make sipr_bit_rate static const
[22:54] <michaelni> If anyone wants a coverity account for ffmpeg, tell me and ill make sure you get one
[22:56] <ubitux> michaelni: what motivated the const ’ static const?
[22:56] <ubitux> some kind of warnings somewhere?
[22:58] <michaelni> for ones within functions gcc (in the past at least) initialized the arrays on the stack each time the function is run when its not static while statics are just initialized once
[22:58] <michaelni> outside functions theres global namespace polution
[22:58] <ubitux> yes i'm not discussing the usefulness of the commits
[22:58] <ubitux> just wondering why now
[22:58] <ubitux> if that's pure hazard or just spotted by some random tool
[22:59] <michaelni> git grep '^ *const[ a-z0-9A-Z_]*\[.*=' | egrep -v 'static|extern|ff_|av_|avpriv_' <-- The tool(tm)
[22:59] <ubitux> ok :)
[23:01] <cone-882> ffmpeg.git 03Michael Niedermayer 07master:6bbcae2c16e7: avcodec/fft: Fix "warning: unused variable"
[23:06] <michaelni> pengvado, seems the CC to you fro the following mail bounced (http://ffmpeg.org/pipermail/ffmpeg-devel/2013-August/146846.html) 
[00:00] --- Mon Aug  5 2013