[FFmpeg-devel] [PATCH] Implement PAFF in H.264

[Michael Niedermayer]

On Thu, Oct 04, 2007 at 03:07:09PM -0400, Jeff Downs wrote:
> On Thu, 4 Oct 2007, Jeff Downs wrote:
> 
> > I'll continue to split as I have time, given how productive this round 
> > was.
> > 
> 
> OK, here is the next round of split patches.  I took these diffs against a 
> tree with the defreflist and reordering patches (posted short time ago) 
> applied, but they will likely also apply clean to current svn.
> 
> Again, in suggested application order with commit message.
> 
> 
[...]
> 8. paff-picmgmt.patch
> Manage Picture buffers for fields as well as frames. Pair complementary 
> fields into one MPV Picture.  Part of PAFF implementation.
> 
> 
> 
> After these, there are two more -- one to indent after #8 and one to 
> actually enable PAFF handling by properly defining FIELD_PICTURE.
> Since the indent one is quite large, I'll wait until these can be looked 
> at to post the last two.
> 
> 	-Jeff

[...]

> @@ -3991,8 +3998,50 @@
>      }
>  
>      if(h0->current_slice == 0){
> -        if(frame_start(h) < 0)
> +        /* See if we have a decoded first field looking for a pair... */
> +        if (s0->first_field) {
> +            assert(s0->current_picture_ptr);
> +            assert(s0->current_picture_ptr->data[0]);
> +            assert(s0->current_picture_ptr->reference != DELAYED_PIC_REF);
> +
> +            /* figure out if we have a complementary field pair */
> +            if (!FIELD_PICTURE || s->picture_structure == last_pic_structure) {
> +                /*
> +                 * Previous field is unmatched. Don't display it, but let it
> +                 * remain for reference if marked as such.
> +                 */
> +                s0->current_picture_ptr = NULL;
> +                s0->first_field = FIELD_PICTURE;

first field is set to 0, 1, FIELD_PICTURE and tested against 0/not 0
this is inconsistent
also it should be here !=0 already


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071008/872098d3/attachment.pgp>