[FFmpeg-devel] [PATCH] Proposal: undefine DEBUG_SEEK in libavformat/utils.c

Thorsten Jordan tjordan
Wed Oct 17 09:25:52 CEST 2007

Michael Niedermayer schrieb:
> Hi
>> this breaks seek regression test (i missed that) as follows, what should
>> be done ?
> hmm, revert and wait for an explanation of the (poor) patch author
> its his patch he has to explain why that happens if he wants the patch
> applied :)
hmm i am not "wanting" but proposed it, as i thought it was trivial and
i didn't know that it breaks regression tests.
It leads to index computation that wouldn't be done without DEBUG_SEEK,
and these calculations give computational overhead when opening large TS
files that you want to play/demux linearily.
If the code only "works" (works -  regression test passed) with a debug
flag on, i suppose the regression test should be updated...

Greetings, Thorsten

More information about the ffmpeg-devel mailing list