[FFmpeg-devel] [RFC] remove lrintf fallback implementation

[Rich Felker]

On Tue, Oct 23, 2007 at 12:20:43AM +0200, Diego Biurrun wrote:
> On Mon, Oct 01, 2007 at 03:55:18PM +0200, Diego Biurrun wrote:
> > In libavutil/internal.h we have a (bad) fallback implementation of
> > lrintf that was added waaaay back in October 2002 by Fabrice:
> > 
> > static av_always_inline long int lrintf(float x)
> > {
> >     return (int)(rint(x));
> > }
> > 
> > I'm not sure which systems still lack lrintf, but we refused to add a
> > fallback implementation of llrint for Cygwin.  So IMO the lrintf
> > fallback should go.
> 
> So nobody has an opinion about this matter (as opposed to an opinion
> about llrint)?  If nobody makes a statement in either direction I will
> drop this issue, albeit reluctantly...

As long as the implementation is generic and not asm, I prefer to
leave it. It's not harming anyone and might be useful.

Rich