[FFmpeg-devel] [PATCH] Adjusting accel flag of liba52

Michael Niedermayer michaelni
Thu Jan 17 18:39:24 CET 2008


On Thu, Jan 17, 2008 at 12:44:55PM -0500, Rich Felker wrote:
> On Thu, Jan 17, 2008 at 06:29:15PM +0100, Michael Niedermayer wrote:
> > On Fri, Jan 18, 2008 at 12:57:21AM +0900, KO Myung-Hun wrote:
> > > Hi/2.
> > > 
> > > Currently, liba52 call just a52_init(0). Because of this, we have no
> > > choice for a proper IMDCT transform.
> > > 
> > > So I add a global flag variable, a52_accel.
> > 
> > rejected
> > not a generic API
> > no av prefix
> > non constant global
> > (each alone means rejection)
> 
> Can we remove liba52 support already to avoid this sort of
> timewasting?

can someone quickly confirm that the "we re faster" benchmarks where
using liba52 with asm/mmx optimizations
if so, yes you can remove it

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080117/e09a975d/attachment.pgp>



More information about the ffmpeg-devel mailing list