[FFmpeg-devel] [PATCH] rmdec: avoid leaving st unitialized

[Ronald S. Bultje]

Hi,

On Sun, Jun 6, 2010 at 6:57 AM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de> wrote:
> this fixes a warning with my gcc version, and I think it even fixes a bug:
> Index: rmdec.c
> ===================================================================
> --- rmdec.c ? ? (revision 23501)
> +++ rmdec.c ? ? (working copy)
> @@ -843,7 +844,7 @@
> ? ? ? ? ? ? ? ? pos = url_ftell(s->pb);
> ? ? ? ? ? ? } else {
> ? ? ? ? ? ? ? ? len=sync(s, &timestamp, &flags, &i, &pos);
> - ? ? ? ? ? ? ? ?if (len > 0)
> + ? ? ? ? ? ? ? ?if (len >= 0)
> ? ? ? ? ? ? ? ? ? ? st = s->streams[i];
> ? ? ? ? ? ? }
>
>
> The next line below this reads:
> ? ? ? ? ? ?if(len<0 || url_feof(s->pb))
> ? ? ? ? ? ? ? ?return AVERROR(EIO);
> so >= 0 fits with this condition, and other places treat a 0 value
> from "sync" as ok.

sync() can not return zero (I've looked at this a couple of times in
the past because the gcc warning annoyed me at some point). So the
patch silences a warning but in reality, it doesn't do anything.

Ronald