[FFmpeg-devel] [PATCH] lavu: add escape API

Stefano Sabatini stefasab at gmail.com
Mon Mar 4 18:44:40 CET 2013


On date Tuesday 2013-02-26 19:29:24 +0100, Nicolas George encoded:
> Le tridi 3 ventôse, an CCXXI, Stefano Sabatini a écrit :
> > +enum AVEscapeMode {
> > +    AV_ESCAPE_MODE_BACKSLASH, ///< Use backslash escaping.
> > +    AV_ESCAPE_MODE_QUOTE    , ///< Use single-quote escaping.
> > +};
> 
> I still do not like the fact that the user is forced to select a mode and
> can not say "just escape the string whatever way (the best way)". Maybe just
> add AV_ESCAPE_MODE_AUTO, and:
> 
>     if (mode == AV_ESCAPE_MODE_AUTO)
> 	mode = AV_ESCAPE_MODE_BACKSLASH; /* TODO: implement a heuristic */

What heuristic do you have in mind?

> 
> ?
> 
> The rest looks ok to me.

Changed.
-- 
FFmpeg = Furious and Fiendish Multimedia Pitiful Excellent God
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-lavu-add-escape-API.patch
Type: text/x-diff
Size: 12564 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130304/e02d2e53/attachment.bin>


More information about the ffmpeg-devel mailing list