[FFmpeg-devel] [PATCH] lavu/eval: rename "new_eval_expr()" to "make_eval_expr()"

[Paul B Mahol]

On 3/5/13, Stefano Sabatini <stefasab at gmail.com> wrote:
> The new name is more semantically and stilistically consistent.
> ---
>  libavutil/eval.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/libavutil/eval.c b/libavutil/eval.c
> index 4875725..c9742b8 100644
> --- a/libavutil/eval.c
> +++ b/libavutil/eval.c
> @@ -452,7 +452,7 @@ static int parse_primary(AVExpr **e, Parser *p)
>      return 0;
>  }
>
> -static AVExpr *new_eval_expr(int type, int value, AVExpr *p0, AVExpr *p1)
> +static AVExpr *make_eval_expr(int type, int value, AVExpr *p0, AVExpr *p1)
>  {
>      AVExpr *e = av_mallocz(sizeof(AVExpr));
>      if (!e)
> @@ -499,7 +499,7 @@ static int parse_factor(AVExpr **e, Parser *p)
>              av_expr_free(e1);
>              return ret;
>          }
> -        e0 = new_eval_expr(e_pow, 1, e1, e2);
> +        e0 = make_eval_expr(e_pow, 1, e1, e2);
>          if (!e0) {
>              av_expr_free(e1);
>              av_expr_free(e2);
> @@ -526,7 +526,7 @@ static int parse_term(AVExpr **e, Parser *p)
>              av_expr_free(e1);
>              return ret;
>          }
> -        e0 = new_eval_expr(c == '*' ? e_mul : e_div, 1, e1, e2);
> +        e0 = make_eval_expr(c == '*' ? e_mul : e_div, 1, e1, e2);
>          if (!e0) {
>              av_expr_free(e1);
>              av_expr_free(e2);
> @@ -549,7 +549,7 @@ static int parse_subexpr(AVExpr **e, Parser *p)
>              av_expr_free(e1);
>              return ret;
>          }
> -        e0 = new_eval_expr(e_add, 1, e1, e2);
> +        e0 = make_eval_expr(e_add, 1, e1, e2);
>          if (!e0) {
>              av_expr_free(e1);
>              av_expr_free(e2);
> @@ -578,7 +578,7 @@ static int parse_expr(AVExpr **e, Parser *p)
>              av_expr_free(e1);
>              return ret;
>          }
> -        e0 = new_eval_expr(e_last, 1, e1, e2);
> +        e0 = make_eval_expr(e_last, 1, e1, e2);
>          if (!e0) {
>              av_expr_free(e1);
>              av_expr_free(e2);
> --
> 1.7.9.5
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

fine for me