[FFmpeg-devel] [PATCH] lavfi/volume: add dynamic expression evaluation

Nicolas George nicolas.george at normalesup.org
Tue Mar 5 16:08:54 CET 2013


Le quartidi 14 ventôse, an CCXXI, Stefano Sabatini a écrit :
> That's a solution (or add a filter variant). The other solution would
> be to make the filter behaves in a different way if the expression is
> constant (CONST OP CONST is detected as constant), which would need
> some hack to the eval code (of course this can't detect things like
> EXPR-EXPR).

Detecting what variables / functions are used in the expression is not
impossible at all, and it would allow to know whether the expression is
constant or not even in complex cases.

> Please tell what you prefer (and feel free to pick the patch and
> improve it yourself if you're in hurry).

Could you make a quick benchmark, using a small frame size (asetnsamples=16
for example): that would greatly help knowing whether it is worth optimizing
that or not.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130305/912fcb9e/attachment.asc>


More information about the ffmpeg-devel mailing list