[FFmpeg-devel] [PATCH] lavc/utils: fix typo and reword message in case of too low bitrate

Stefano Sabatini stefasab at gmail.com
Sun Mar 10 13:46:35 CET 2013


On date Sunday 2013-03-10 13:38:55 +0100, Clément Bœsch encoded:
> On Sun, Mar 10, 2013 at 11:01:27AM +0100, Stefano Sabatini wrote:
> > ---
> >  libavcodec/utils.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/utils.c b/libavcodec/utils.c
> > index befb948..e42b72e 100644
> > --- a/libavcodec/utils.c
> > +++ b/libavcodec/utils.c
> > @@ -1044,7 +1044,7 @@ int attribute_align_arg avcodec_open2(AVCodecContext *avctx, const AVCodec *code
> >          }
> >          if (   (avctx->codec_type == AVMEDIA_TYPE_VIDEO || avctx->codec_type == AVMEDIA_TYPE_AUDIO)
> >              && avctx->bit_rate>0 && avctx->bit_rate<1000) {
> > -            av_log(avctx, AV_LOG_WARNING, "Bitrate %d is extreemly low, did you mean %dk\n", avctx->bit_rate, avctx->bit_rate);
> > +            av_log(avctx, AV_LOG_WARNING, "Bitrate %d is extremely low, maybe you mean %dk\n", avctx->bit_rate, avctx->bit_rate);
> 
> While fixing the extrem- typo is OK, I like the question form. Maybe add a
> '?' instead. That said, both forms are fine with me.

Pushed my variant, as I don't like programs asking for questions, thanks.
-- 
FFmpeg = Fascinating Fancy Murdering Pure ExchanGer


More information about the ffmpeg-devel mailing list