[FFmpeg-devel] [PATCH] lavfi/buffersrc: set channel layout if it is known.

Michael Niedermayer michaelni at gmx.at
Sat Mar 16 23:56:04 CET 2013


On Sat, Mar 16, 2013 at 12:31:47AM +0100, Nicolas George wrote:
> Le sextidi 26 ventôse, an CCXXI, Michael Niedermayer a écrit :
> > >      case AVMEDIA_TYPE_AUDIO:
> > > +        if (!frame->channel_layout)
> > > +            frame->channel_layout = s->channel_layout;
> > this could set an inconsistent layout i think,
> > consider s->channel_layout is mono and frame->channels=3
> 
> At this point, if s->channel_layout is mono, then s->channels is 1.
> Therefore it should be caught by CHECK_AUDIO_PARAM_CHANGE just below that
> anyway.

yes until someone removes that to allow midstream configuration
changes

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130316/5ccd9d16/attachment.asc>


More information about the ffmpeg-devel mailing list