[FFmpeg-devel] [PATCH] avfilter: split asrc_anullsrc

[Stefano Sabatini]

On date Saturday 2013-03-16 18:54:06 +0100, Michael Niedermayer encoded:
> asrc_anullsrc is renamed to asrc_asilencesrc
> and asrc_anullsrc is taken from 4750b05d67fd87263cb767b896e1cf55713a39de
> This makes our anullsrc match the one from the fork. And should
> improve compatibility between them.
> 
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  doc/filters.texi               |    6 +-
>  libavfilter/Makefile           |    1 +
>  libavfilter/allfilters.c       |    1 +
>  libavfilter/asrc_anullsrc.c    |   94 +--------------------------
>  libavfilter/asrc_asilencesrc.c |  141 ++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 149 insertions(+), 94 deletions(-)
>  create mode 100644 libavfilter/asrc_asilencesrc.c

I'm a bit against this one, and I'd ask to keep the few differences
with the fork (options which were meant to simplify usage).

Also to call it "asilencesrc" relies on a disputable behavior for
which requested frames are silent (even when they are never read,
which just adds CPU cycles).

If we want to have a silence source we could add an option to this
one.
-- 
FFmpeg = Fundamental and Faithful Mortal Prodigious Ecstatic Game