[FFmpeg-devel] [PATCH 1/2] libavutil/libavfilter: opencl wrapper based on comments on 20130328

[Michael Niedermayer]

On Fri, Mar 29, 2013 at 04:51:30PM +0800, Wei Gao wrote:
> Hi, Thanks for your reply. some questions and explanations
> 
> Thanks
> Best regards
> 
> 
> 2013/3/29 Stefano Sabatini <stefasab at gmail.com>
> 
> > On date Thursday 2013-03-28 20:57:44 +0800, Wei Gao encoded:
> > >
> >
> > > From 38aa9bb65c63d44cd1586383f37197bee93c61ab Mon Sep 17 00:00:00 2001
> > > From: highgod0401 <highgod0401 at gmail.com>
> > > Date: Thu, 28 Mar 2013 20:42:21 +0800
> > > Subject: [PATCH 1/2] opencl wrapper based on comments on 20130328
> > >
> > > ---
> >
> >
> > > +        /*initialize devices, context, command_queue*/
> > > +        AVDictionaryEntry *opt_entry = av_dict_get(options,
> > "build_option", NULL, 0);
> >
> > "build_options"?
> >
> > "build_flags" also seems fine, whatever is more consistent with the
> > specification text.
> >
> I reference the document of OpenCL Specification Version: 1.2, it named
> build options.
> 

> >
> > > +        ret = init_opencl_env(&gpu_env, ext_opencl_info);
> > > +        if (ret < 0)
> > > +            goto end;
> > > +        /*initialize program, kernel_name, kernel_count*/
> >
> > > +        ret = compile_kernel_file(&gpu_env, opt_entry->value);
> >
> > crash if opt_entry is NULL?
> >
> will not crush, the OpenCL API "clBuildProgram" accept the NULL pointer,
> the kernel can be compiled too.

i think stefano meant that opt_entry->value will crash if opt_entry
is NULL


[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130329/8eb8b42a/attachment.asc>