[FFmpeg-devel] [PATCH 2/2] libavutil/libavfilter: deshake opencl filter based on comments on 20130331

Michael Niedermayer michaelni at gmx.at
Sun Mar 31 12:57:38 CEST 2013


On Sun, Mar 31, 2013 at 03:58:24PM +0800, Wei Gao wrote:
[...]
> diff --git a/libavfilter/vf_deshake.c b/libavfilter/vf_deshake.c
> index 138c25d..5172a39 100644
> --- a/libavfilter/vf_deshake.c
> +++ b/libavfilter/vf_deshake.c
> @@ -1,6 +1,7 @@
>  /*
>   * Copyright (C) 2010 Georg Martius <georg.martius at web.de>
>   * Copyright (C) 2010 Daniel G. Taylor <dan at programmer-art.org>
> + * Copyright (C) 2013 Wei Gao <weigao at multicorewareinc.com>
>   *
>   * This file is part of FFmpeg.
>   *
> @@ -60,6 +61,7 @@
>  #include "libavcodec/dsputil.h"
>  
>  #include "transform.h"
> +#include "deshake_opencl.h"
>  
>  #define CHROMA_WIDTH(link)  -((-link->w) >> av_pix_fmt_desc_get(link->format)->log2_chroma_w)
>  #define CHROMA_HEIGHT(link) -((-link->h) >> av_pix_fmt_desc_get(link->format)->log2_chroma_h)
> @@ -106,6 +108,13 @@ typedef struct {
>      int cx;
>      int cy;
>      char *filename;            ///< Motion search detailed log filename
> +    int is_opencl;
> +    FFDeshakeOpenclEnv opencl_env;
> +    int (* transform)(FFDeshakeOpenclEnv *, int, int, int, int, const float *, const float *,
> +               enum InterpolateMethod, enum FillMethod , AVFrame *, AVFrame *);


> +    int (* opencl_init)(AVFilterContext *, FFDeshakeOpenclEnv *);
> +    void (* opencl_uninit)(FFDeshakeOpenclEnv *);
> +    int (* opencl_process_inout_buf)(AVFrame *, AVFrame *, FFDeshakeOpenclEnv *);

these 3 function pointers could be droped and the functions called
directly in the current design

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130331/06274129/attachment.asc>


More information about the ffmpeg-devel mailing list