[FFmpeg-devel] [PATCH]Check if free atoms in mov are actually moov atoms

[Robert Krüger]

On Sat, May 31, 2014 at 10:29 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> On Thursday 06 March 2014 01:29:13 pm Carl Eugen Hoyos wrote:
>> Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
>> > Attached patch fixes ticket #1551, this is how vlc decodes
>> > the sample.
>>
>> As-is, this is probably not such a good idea, the vlc code
>> only uses the "bad" atom if no moov atom was found:
>> http://git.videolan.org/?p=vlc.git;a=commitdiff;h=b5a213db
>
> New patch attached.
>
> Please comment, Carl Eugen
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

Do I understand it correctly that this now happens by default? This
might be a problem for api users who use libav* to determine if
something is a valid file, because it will now treat an invalid file
as a valid file. The log output does not help them. I think this is a
good default for a player but not for a general purpose api and there
should at least be a switch to turn it off or on (maybe someting along
the lines of strict_std_compliance in codec context or an
AVFMT_FLAG_*). I don't know about the policies for versioning but this
may be a reason to bump as it modifies behaviour significantly.

Never mind the comment, if I misinterpreted the code.