[FFmpeg-devel] A question about flushing the Vorbis decoder.

[Michael Niedermayer]

On Wed, Jun 04, 2014 at 05:59:45PM -0700, Dale Curtis wrote:
> On Wed, Jun 4, 2014 at 5:54 PM, Michael Niedermayer <michaelni at gmx.at>
> wrote:
> 
> > On Wed, Jun 04, 2014 at 03:25:15PM -0700, Dale Curtis wrote:
> > > Should vorbis_decode_flush() set vc->first_frame = 0? Or are clients
> > > expected to manage dropping the first buffer after seeks to the stream
> > > start?
> >
> > Doesnt reseting first_frame on flush for vorbis make it behave
> > differently than other decoders ?
> >
> 
> No idea, hence my question :) I will say that not setting that means
> clients which call flush prior to a seek(0) get a buffer that's not there
> on the first decoding pass. That said, all future buffers are correctly
> bit-exact. It's just the extra buffer that I'm curious about.

i guess its better to discard the initial not correct data, so
suggested change made

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140607/c30e545b/attachment.asc>