[FFmpeg-devel] [PATCH] x86: huffyuv: fix {add,diff}_int16

[Michael Niedermayer]

On Wed, Jun 11, 2014 at 09:31:07PM +0200, Christophe Gisquet wrote:
> 2014-06-11 21:18 GMT+02:00 Christophe Gisquet <christophe.gisquet at gmail.com>:
> [SNIP]
> 
> Now that I think of it, probably this other patch is a tad better.
> Ideally one would push/pop only if needed, ie len is %(2*mmsize) and
> extra reg needed is callee-saved.
> 
> It seems to fix all the fate failures on win32 here, so it may fix others.
> 
> -- 
> Christophe

>  lossless_videodsp.asm |   22 ++++++++++++----------
>  1 file changed, 12 insertions(+), 10 deletions(-)
> bccff8d49fbc446d29126de2c2c837b779fc1365  0001-x86-huffyuv-fix-add-diff-_int16.patch
> From 30c5336106f05e9ec6d30a7b3af5e2a6a5781a85 Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet <christophe.gisquet at gmail.com>
> Date: Wed, 11 Jun 2014 21:13:23 +0200
> Subject: [PATCH] x86: huffyuv: fix {add,diff}_int16
> 
> They used an extra, undeclared register. Fixes a crash in
> fate-vsynth3-ffvhuff444p16

applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140612/f98ce27f/attachment.asc>