[FFmpeg-devel] [PATCH] avcodec/ppc/idct_altivec: add plain idct()

Christophe Gisquet christophe.gisquet at gmail.com
Sat Jun 14 20:22:15 CEST 2014


2014-06-14 20:06 GMT+02:00 Michael Niedermayer <michaelni at gmx.at>:
> i dont really know altivec / the advantages of direct assignment vs
> using vec_st*() and i dont have hw to test either
> so if my patch is silly in some way, please submit a correct one
> and ill apply it

I was cargo-culting as I don't know altivec, and actually, block is
already vec_s16, so I had the offsets wrong. I only commented in case
compilation failed.

Your solution works, so unless Carl wants to take the time to verify
if the 2 syntaxes generate different instructions with objdump, yours
is fine and should be applied.

And if it happens not to be, the vec_st stuff will have to be checked.

More information about the ffmpeg-devel mailing list