[FFmpeg-devel] [PATCH 1/5] avformat: add codec_time_base

Michael Niedermayer michaelni at gmx.at
Wed Jun 18 22:53:21 CEST 2014

On Wed, Jun 18, 2014 at 02:37:02PM -0500, Hendrik Leppkes wrote:
> On Wed, Jun 18, 2014 at 2:35 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > This is unambigously the codec timebase, while AVStream.time_base
> > changes its meaning when avpriv_set_pts_info() is called
> >
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> And why wouldn't I simply access st->codec->time_base instead of
> st->codec_time_base?
> Seems a bit redundant, doesn't it?

absolutely yes, accessing it directly is the best solution
but libav moves away from this it seems, see
so i assumed that if we want to stay compatible to that API its better
to make similar changes to our code
and the timebase field with that new API only permits access to one
of the timebases depening on when its accessed and its the wrong one
for our code in some cases ...

better ideas are certainly welcome


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140618/f103c5a9/attachment.asc>

More information about the ffmpeg-devel mailing list