[FFmpeg-devel] [PATCH] lavfi/overlay: show incoming frames on debug messages

Michael Niedermayer michaelni at gmx.at
Fri Jun 20 15:06:06 CEST 2014

On Fri, Jun 20, 2014 at 02:56:00PM +0200, Stefano Sabatini wrote:
> This is especially useful to debug queue overflow issues.
> Ideally we should be able to set the debug message at the
> dualinput/framesync level, but they do not have the information related
> to the filter context and the inlink, so cannot access much useful
> information.
> Signed-off-by: Stefano Sabatini <stefasab at gmail.com>
> ---
>  libavfilter/vf_overlay.c | 2 ++
>  1 file changed, 2 insertions(+)

LGTM, but maybe others have ideas on how to improve it, like
making it not print always at debug level, which could be annoying
if all filters do this and one is debuging something unlreated to
then again AV_CLASS_CATEGORY could potentially be used to avoid that

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140620/e080b1ca/attachment.asc>

More information about the ffmpeg-devel mailing list