[FFmpeg-devel] [PATCH 2/2] lavd/opengl_enc: check strings before parsing them.

Nicolas George george at nsup.org
Mon Feb 17 14:50:00 EET 2020


Fix a segfault if OpenGL was not initialized before calling
write_header().

Signed-off-by: Nicolas George <george at nsup.org>
---
 libavdevice/opengl_enc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c
index fa94345a7c..3d60f7d068 100644
--- a/libavdevice/opengl_enc.c
+++ b/libavdevice/opengl_enc.c
@@ -588,6 +588,10 @@ static av_cold int opengl_read_limits(AVFormatContext *h)
 
     version = glGetString(GL_VERSION);
     extensions = glGetString(GL_EXTENSIONS);
+    if (!version || !extensions) {
+        av_log(h, AV_LOG_ERROR, "OpenGL not available\n");
+        return AVERROR(ENOSYS);
+    }
 
     av_log(h, AV_LOG_DEBUG, "OpenGL version: %s\n", version);
     sscanf(version, "%d.%d", &major, &minor);
-- 
2.25.0



More information about the ffmpeg-devel mailing list