[FFmpeg-devel] [PATCH 03/12] lavfi: drop vf_qp

Anton Khirnov anton at khirnov.net
Mon Feb 24 18:50:18 EET 2020


Quoting Paul B Mahol (2020-02-24 17:02:52)
> On 2/24/20, James Almer <jamrial at gmail.com> wrote:
> > On Monday, February 24, 2020, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> >>
> >>
> >>
> >>> Am 24.02.2020 um 15:54 schrieb Anton Khirnov <anton at khirnov.net>:
> >>>
> >>> Quoting Carl Eugen Hoyos (2020-02-24 13:50:57)
> >>>>> Am Mo., 24. Feb. 2020 um 13:40 Uhr schrieb Anton Khirnov <
> > anton at khirnov.net>:
> >>>>>
> >>>>> It fundamentally depends on an API that has been deprecated for five
> >>>>> years, has seen no commits since that time and is of highly dubious
> >>>>> usefulness.
> >>>>
> >>>> Please explain how the removed functionality was replaced.
> >>>
> >>> It was not, for the reasons mentioned in the commit message. In my view,
> >>> the fact that nobody fixed it in all that time proves that nobody cares
> >>> about this functionality and thus that there is no value in keeping it.
> >>
> >> In this case your patch set is not acceptable: I strongly suggest you
> > work on something that improves FFmpeg instead of removing features.
> >>
> >> Carl Eugen
> >
> > Anton argued why it should be removed. You should do the same about why it
> > should not. Simply saying you are against removing features other
> > developers consider useless is not enough.
> 
> Filter as is was simply never marked for deprecation, same applies for
> removed features to other filters in this set.

So what? It produced deprecation warnings on every build for five years.

Are you claiming you have a use case for it? Or know about someone who
does?

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list