[FFmpeg-devel] [PATCH] fate: add scale filters for big-endian architectures.

Michael Niedermayer michael at niedermayer.cc
Thu Oct 1 22:40:16 EEST 2020


On Wed, Sep 30, 2020 at 08:44:24PM +0200, Nicolas George wrote:
> Michael Niedermayer (12020-09-30):
> > > confirmed to work on qemu mips
> > > so should be ok
> 
> Sorry, I missed that part of your mail. Pushed.
> 
> > ping, big endian is still broken
> 
> A few minutes ago, I still did not see these failures on
> fate.ffmpeg.org. Any idea why?

the machiene the mips fate client VM was on crashed and i forgot to restart
all parts


> 
> > also i realize that this has a disadvantage, and that is that it adds
> > quite a bit of extra human work. Because now every time a fate test
> > is added theres an additional thing to consider which is specific
> > to big endian and which most developers cannot easily test
> 
> I think you are painting this too darkly, the pattern is quite simple:
> tests that output high bit depth require a final conversion filter. We
> can be careful when reviewing commits that add tests. And if it does not
> work, there is something weirdly broken that needs to be investigated,
> so it is a good thing we know about it.

its better to automate it. patchwork already tests submitted patches, this
should be extended to cover big endian as few people are able to easily test
that

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20201001/bce84ad1/attachment.sig>


More information about the ffmpeg-devel mailing list