[FFmpeg-devel] [PATCH] vf_v360: fix visibility test for fisheye projection

Moritz Barsnick barsnick at gmx.net
Fri Mar 19 12:19:26 EET 2021


On Fri, Mar 19, 2021 at 20:42:04 +1100, Daniel Playfair Cal wrote:
> -    const int visible = hypotf(uf, vf) <= 0.5f;
> +    const int visible = -0.5 < uf && uf < 0.5 && -0.5 < vf && vf < 0.5;

Please avoid double constants in float expressions, they propagate the
whole calculation to a double. I.e. use "0.5f" instead of "0.5".

(Also in one of your other patches.)

Cheers,
Moritz


More information about the ffmpeg-devel mailing list