October 2019 - ffmpeg-cvslog - lists.ffmpeg.org

avcodec/hcom: Check the root entry and the right entries
by Michael Niedermayer 24 Oct '19

24 Oct '19

ffmpeg | branch: master | Michael Niedermayer <michael(a)niedermayer.cc> | Mon Oct 7 16:56:11 2019 +0200| [4834ec926aa569cf25c797e22643d4735880b7a1] | committer: Michael Niedermayer avcodec/hcom: Check the root entry and the right entries Fixes: Segfault Fixes: 17991/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HCOM_fuzzer-5647235349479424 Also fixes related memleak Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael(a)niedermayer.cc> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=4834ec926aa569cf2… --- libavcodec/hcom.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/hcom.c b/libavcodec/hcom.c index 0559b050c3..8300676f98 100644 --- a/libavcodec/hcom.c +++ b/libavcodec/hcom.c @@ -66,8 +66,15 @@ static av_cold int hcom_init(AVCodecContext *avctx) s->dict[i].r = AV_RB16(avctx->extradata + 6 + 4 * i + 2); if (s->dict[i].l >= 0 && (s->dict[i].l >= s->dict_entries || - s->dict[i].r >= s->dict_entries)) + s->dict[i].r >= s->dict_entries || + s->dict[i].r < 0 )) { + av_freep(&s->dict); return AVERROR_INVALIDDATA; + } + } + if (s->dict[0].l < 0) { + av_freep(&s->dict); + return AVERROR_INVALIDDATA; } avctx->sample_fmt = AV_SAMPLE_FMT_U8;

1 0

avcodec/qdrw: Check input for header/skiped space before get_buffer()
by Michael Niedermayer 24 Oct '19

24 Oct '19

ffmpeg | branch: master | Michael Niedermayer <michael(a)niedermayer.cc> | Mon Oct 7 16:14:32 2019 +0200| [b63fbc19c09d0b42da4f83c21fcf362d6ed7c545] | committer: Michael Niedermayer avcodec/qdrw: Check input for header/skiped space before get_buffer() Fixes: Timeout (21sec -> 0.8sec) Fixes: 17990/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDRAW_fuzzer-5200374436200448 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael(a)niedermayer.cc> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=b63fbc19c09d0b42d… --- libavcodec/qdrw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/qdrw.c b/libavcodec/qdrw.c index 32ba410968..65279c9805 100644 --- a/libavcodec/qdrw.c +++ b/libavcodec/qdrw.c @@ -455,6 +455,8 @@ static int decode_frame(AVCodecContext *avctx, avpriv_request_sample(avctx, "Pack type %d", pack_type); return AVERROR_PATCHWELCOME; } + if (bytestream2_get_bytes_left(&gbc) < 30) + return AVERROR_INVALIDDATA; if ((ret = ff_get_buffer(avctx, p, 0)) < 0) return ret;

1 0

tools/target_dec_fuzzer: Adjust threshold for CFHD
by Michael Niedermayer 24 Oct '19

24 Oct '19

ffmpeg | branch: master | Michael Niedermayer <michael(a)niedermayer.cc> | Mon Oct 7 15:32:06 2019 +0200| [8caa7166676eaab89dd5cab5ab4ec506b00db70d] | committer: Michael Niedermayer tools/target_dec_fuzzer: Adjust threshold for CFHD Fixes: Timeout (18sec -> 5sec) Fixes: 17977/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CFHD_fuzzer-5186112762413056 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael(a)niedermayer.cc> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8caa7166676eaab89… --- tools/target_dec_fuzzer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index b943423db5..39973504ae 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_fuzzer.c @@ -138,6 +138,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { switch (c->id) { // Allows a small input to generate gigantic output case AV_CODEC_ID_BINKVIDEO: maxpixels /= 32; break; + case AV_CODEC_ID_CFHD: maxpixels /= 128; break; case AV_CODEC_ID_DIRAC: maxpixels /= 8192; break; case AV_CODEC_ID_DXV: maxpixels /= 32; break; case AV_CODEC_ID_FFWAVESYNTH: maxsamples /= 16384; break;

1 0

tools/target_dec_fuzzer: Adjust ffwavesynth threshold
by Michael Niedermayer 24 Oct '19

24 Oct '19

ffmpeg | branch: master | Michael Niedermayer <michael(a)niedermayer.cc> | Mon Oct 7 14:53:28 2019 +0200| [000494fed9326a3ecee485cbb7afb569519098e3] | committer: Michael Niedermayer tools/target_dec_fuzzer: Adjust ffwavesynth threshold ffwavesynth can produce large amounts of data relatively slowly on very small input Fixes: Timeout (60sec -> 9sec) Fixes: 17970/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFWAVESYNTH_fuzzer-5689121279836160 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael(a)niedermayer.cc> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=000494fed9326a3ec… --- tools/target_dec_fuzzer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index d6838fb35b..b943423db5 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_fuzzer.c @@ -140,6 +140,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { case AV_CODEC_ID_BINKVIDEO: maxpixels /= 32; break; case AV_CODEC_ID_DIRAC: maxpixels /= 8192; break; case AV_CODEC_ID_DXV: maxpixels /= 32; break; + case AV_CODEC_ID_FFWAVESYNTH: maxsamples /= 16384; break; case AV_CODEC_ID_MSRLE: maxpixels /= 16; break; case AV_CODEC_ID_QTRLE: maxpixels /= 16; break; case AV_CODEC_ID_SANM: maxpixels /= 16; break;

1 0

avcodec/ralf: Skip initializing unused filter variables
by Michael Niedermayer 24 Oct '19

24 Oct '19

ffmpeg | branch: master | Michael Niedermayer <michael(a)niedermayer.cc> | Sat Oct 5 19:34:17 2019 +0200| [f4ecf6c39de9a7cc1dae70cf87c225771001e883] | committer: Michael Niedermayer avcodec/ralf: Skip initializing unused filter variables Fixes: left shift of negative value -1 Fixes: 17890/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RALF_fuzzer-5643307467669504 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael(a)niedermayer.cc> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=f4ecf6c39de9a7cc1… --- libavcodec/ralf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/ralf.c b/libavcodec/ralf.c index 006ab46414..1d881cf7ae 100644 --- a/libavcodec/ralf.c +++ b/libavcodec/ralf.c @@ -234,8 +234,10 @@ static int decode_channel(RALFContext *ctx, GetBitContext *gb, int ch, int *dst = ctx->channel_data[ch]; ctx->filter_params = get_vlc2(gb, set->filter_params.table, 9, 2); - ctx->filter_bits = (ctx->filter_params - 2) >> 6; - ctx->filter_length = ctx->filter_params - (ctx->filter_bits << 6) - 1; + if (ctx->filter_params > 1) { + ctx->filter_bits = (ctx->filter_params - 2) >> 6; + ctx->filter_length = ctx->filter_params - (ctx->filter_bits << 6) - 1; + } if (ctx->filter_params == FILTER_RAW) { for (i = 0; i < length; i++)

1 0

avcodec/takdec: Fix overflow with large sample rates
by Michael Niedermayer 24 Oct '19

24 Oct '19

ffmpeg | branch: master | Michael Niedermayer <michael(a)niedermayer.cc> | Sat Oct 5 19:52:53 2019 +0200| [42eb78059d149abcd994f46c8b8a0dd98e86b594] | committer: Michael Niedermayer avcodec/takdec: Fix overflow with large sample rates Fixes: signed integer overflow: 2147483647 + 511 cannot be represented in type 'int' Fixes: 17899/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TAK_fuzzer-5719753322135552 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael(a)niedermayer.cc> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=42eb78059d149abcd… --- libavcodec/takdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/takdec.c b/libavcodec/takdec.c index 4fb5825532..8ec87ab509 100644 --- a/libavcodec/takdec.c +++ b/libavcodec/takdec.c @@ -176,8 +176,8 @@ static void set_sample_rate_params(AVCodecContext *avctx) } else { shift = 0; } - s->uval = FFALIGN(avctx->sample_rate + 511 >> 9, 4) << shift; - s->subframe_scale = FFALIGN(avctx->sample_rate + 511 >> 9, 4) << 1; + s->uval = FFALIGN(avctx->sample_rate + 511LL >> 9, 4) << shift; + s->subframe_scale = FFALIGN(avctx->sample_rate + 511LL >> 9, 4) << 1; } static av_cold int tak_decode_init(AVCodecContext *avctx)

1 0

[ffmpeg-web] branch master updated. fce4352 web/css: make download button smaller
by ffmpeg-git＠ffmpeg.org 24 Oct '19

24 Oct '19

The branch, master has been updated via fce4352d00a934c78e1cd366c0d5e08a86223322 (commit) from b293ec7188b6b39ac769f358a2f4a95d0a49c1b7 (commit) - Log ----------------------------------------------------------------- commit fce4352d00a934c78e1cd366c0d5e08a86223322 Author: Lou Logan <lou(a)lrcd.com> AuthorDate: Thu Oct 24 11:39:57 2019 -0800 Commit: Lou Logan <lou(a)lrcd.com> CommitDate: Thu Oct 24 11:40:56 2019 -0800 web/css: make download button smaller It was made too big when changing "Download" to "Download Source Code". Signed-off-by: Lou Logan <lou(a)lrcd.com> diff --git a/src/less/style.less b/src/less/style.less index 26b8862..c83f3e6 100644 --- a/src/less/style.less +++ b/src/less/style.less @@ -395,14 +395,14 @@ code { text-align: center; margin: 160px auto; .btn { - font-size: 3em; + font-size: 2em; padding: 3%; display: inline-block; margin-bottom: 5px; } small { display: block; - font-size: 0.4em; + font-size: 0.5em; } } h2.description { ----------------------------------------------------------------------- Summary of changes: src/less/style.less | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) hooks/post-receive --

1 0

doc/filters: fix another typo
by Paul B Mahol 24 Oct '19

24 Oct '19

ffmpeg | branch: master | Paul B Mahol <onemda(a)gmail.com> | Thu Oct 24 21:42:00 2019 +0200| [37d8ae9da8ac9f3dd01d30996b538c82ba4d8085] | committer: Paul B Mahol doc/filters: fix another typo > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=37d8ae9da8ac9f3dd… --- doc/filters.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 32c2c885d8..68441f8e28 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -14299,7 +14299,7 @@ Set detection threshold factor. Default is 1. Lower is stricter. @item skip -Set how many pixels to skip when sampling frames. Defalt is 1. +Set how many pixels to skip when sampling frames. Default is 1. Allowed range is from 1 to 1024. @item bypass

1 0

[ffmpeg-web] branch master updated. b293ec7 web/download: general improvements
by ffmpeg-git＠ffmpeg.org 24 Oct '19

24 Oct '19

The branch, master has been updated via b293ec7188b6b39ac769f358a2f4a95d0a49c1b7 (commit) from a5b4e10bcb0341b80cdb7758fdfc7de5cd3120f0 (commit) - Log ----------------------------------------------------------------- commit b293ec7188b6b39ac769f358a2f4a95d0a49c1b7 Author: Lou Logan <lou(a)lrcd.com> AuthorDate: Mon Oct 21 13:39:41 2019 -0800 Commit: Lou Logan <lou(a)lrcd.com> CommitDate: Thu Oct 24 11:23:06 2019 -0800 web/download: general improvements Mention big download button is for source code. Mention "executable files" for Windows users in subheader. State that FFmpeg only provides source code. Rename OS X to macOS. Remove PPA to EOL Ubuntu Trusty. Add button to Old Releases. Signed-off-by: Lou Logan <lou(a)lrcd.com> Signed-off-by: Paul B Mahol <onemda(a)gmail.com> diff --git a/src/download b/src/download index ce7e047..a8fdc26 100644 --- a/src/download +++ b/src/download @@ -3,7 +3,7 @@ <div class="btn-download-wrapper"> <a href="https://ffmpeg.org/releases/ffmpeg-4.2.1.tar.bz2" class="btn btn-success"> <i class="fa fa-cloud-download"></i> - Download + Download Source Code <small>ffmpeg-4.2.1.tar.bz2</small> </a> <br> @@ -26,8 +26,8 @@ <div class="well" id="get-packages"> <h3> <i class="fa fa-download"></i> - Get the packages</h3> - + Get packages & executable files</h3> + <p>FFmpeg only provides source code. Below are some links that provide it already compiled and ready to go.</p> <div class="os-selector"> <div class="row"> <div class="col-xs-4"> @@ -60,11 +60,7 @@ <strong>Debian</strong> – deb-multimedia packages for Oldstable, Stable, Testing, Unstable </a> <a href="https://launchpad.net/ubuntu/+source/ffmpeg" class="list-group-item"> - <strong>Ubuntu</strong> – Official packages for Vivid, Wily, Xenial - </a> - <a href="https://launchpad.net/~mc3man/+archive/ubuntu/trusty-media" class="list-group-item"> - <strong>Ubuntu</strong> – Ubuntu Multimedia for Trusty PPA. Provides static binaries - from most recent release branch. + <strong>Ubuntu</strong> – Official packages </a> <a class="list-group-item" href="https://rpmfusion.org/"> <strong>Fedora</strong> and <strong>Red Hat Enterprise Linux</strong> packages @@ -80,18 +76,18 @@ </div>  <div id="build-windows" class="tab-pane active"> - <h3>Windows Packages</h3> + <h3>Windows EXE Files</h3> <div class="list-group"> <a class="list-group-item" href="https://ffmpeg.zeranoe.com/builds/"> - <strong>Windows</strong> Builds + Windows builds by Zeranoe </a> </div>  </div>  <div id="build-mac" class="tab-pane active"> - <h3>OS X Packages</h3> + <h3>macOS</h3> <div class="list-group"> <a class="list-group-item" href="https://evermeet.cx/ffmpeg/"> @@ -541,5 +537,9 @@ libpostproc 53. 3.100</pre> Older versions are available at the <a href="olddownload.html">Old Releases</a> page. </p> - + <div class="row"> + <div class="col-md-3"> + <a class="btn btn-success" href="olddownload.html">Get old releases</a> + </div>  + </div>  </div>  ----------------------------------------------------------------------- Summary of changes: src/download | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) hooks/post-receive --

1 0

avcodec/interplayvideo: cosmetics
by Paul B Mahol 24 Oct '19

24 Oct '19

ffmpeg | branch: master | Paul B Mahol <onemda(a)gmail.com> | Thu Oct 24 15:30:08 2019 +0200| [9bf5e7992f03e36f7721ad592a1d16092952461f] | committer: Paul B Mahol avcodec/interplayvideo: cosmetics > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9bf5e7992f03e36f7… --- libavcodec/interplayvideo.c | 138 ++++++++++++++++++++++---------------------- 1 file changed, 69 insertions(+), 69 deletions(-) diff --git a/libavcodec/interplayvideo.c b/libavcodec/interplayvideo.c index c26ffbaee7..b0a4953cb0 100644 --- a/libavcodec/interplayvideo.c +++ b/libavcodec/interplayvideo.c @@ -1231,83 +1231,83 @@ static int ipvideo_decode_frame(AVCodecContext *avctx, s->decoding_map_size = AV_RL16(buf + 4); s->skip_map_size = AV_RL16(buf + 6); - switch(frame_format) { - case 0x06: - if (s->decoding_map_size) { - av_log(avctx, AV_LOG_ERROR, "Decoding map for format 0x06\n"); - return AVERROR_INVALIDDATA; - } + switch (frame_format) { + case 0x06: + if (s->decoding_map_size) { + av_log(avctx, AV_LOG_ERROR, "Decoding map for format 0x06\n"); + return AVERROR_INVALIDDATA; + } - if (s->skip_map_size) { - av_log(avctx, AV_LOG_ERROR, "Skip map for format 0x06\n"); - return AVERROR_INVALIDDATA; - } + if (s->skip_map_size) { + av_log(avctx, AV_LOG_ERROR, "Skip map for format 0x06\n"); + return AVERROR_INVALIDDATA; + } - if (s->is_16bpp) { - av_log(avctx, AV_LOG_ERROR, "Video format 0x06 does not support 16bpp movies\n"); - return AVERROR_INVALIDDATA; - } + if (s->is_16bpp) { + av_log(avctx, AV_LOG_ERROR, "Video format 0x06 does not support 16bpp movies\n"); + return AVERROR_INVALIDDATA; + } - /* Decoding map for 0x06 frame format is at the top of pixeldata */ - s->decoding_map_size = ((s->avctx->width / 8) * (s->avctx->height / 8)) * 2; - s->decoding_map = buf + 8 + 14; /* 14 bits of op data */ - video_data_size -= s->decoding_map_size + 14; - if (video_data_size <= 0 || s->decoding_map_size == 0) - return AVERROR_INVALIDDATA; + /* Decoding map for 0x06 frame format is at the top of pixeldata */ + s->decoding_map_size = ((s->avctx->width / 8) * (s->avctx->height / 8)) * 2; + s->decoding_map = buf + 8 + 14; /* 14 bits of op data */ + video_data_size -= s->decoding_map_size + 14; + if (video_data_size <= 0 || s->decoding_map_size == 0) + return AVERROR_INVALIDDATA; - if (buf_size < 8 + s->decoding_map_size + 14 + video_data_size) - return AVERROR_INVALIDDATA; + if (buf_size < 8 + s->decoding_map_size + 14 + video_data_size) + return AVERROR_INVALIDDATA; - bytestream2_init(&s->stream_ptr, buf + 8 + s->decoding_map_size + 14, video_data_size); + bytestream2_init(&s->stream_ptr, buf + 8 + s->decoding_map_size + 14, video_data_size); - break; + break; - case 0x10: - if (! s->decoding_map_size) { - av_log(avctx, AV_LOG_ERROR, "Empty decoding map for format 0x10\n"); - return AVERROR_INVALIDDATA; - } + case 0x10: + if (! s->decoding_map_size) { + av_log(avctx, AV_LOG_ERROR, "Empty decoding map for format 0x10\n"); + return AVERROR_INVALIDDATA; + } - if (! s->skip_map_size) { - av_log(avctx, AV_LOG_ERROR, "Empty skip map for format 0x10\n"); - return AVERROR_INVALIDDATA; - } + if (! s->skip_map_size) { + av_log(avctx, AV_LOG_ERROR, "Empty skip map for format 0x10\n"); + return AVERROR_INVALIDDATA; + } - if (s->is_16bpp) { - av_log(avctx, AV_LOG_ERROR, "Video format 0x10 does not support 16bpp movies\n"); - return AVERROR_INVALIDDATA; - } + if (s->is_16bpp) { + av_log(avctx, AV_LOG_ERROR, "Video format 0x10 does not support 16bpp movies\n"); + return AVERROR_INVALIDDATA; + } - if (buf_size < 8 + video_data_size + s->decoding_map_size + s->skip_map_size) - return AVERROR_INVALIDDATA; + if (buf_size < 8 + video_data_size + s->decoding_map_size + s->skip_map_size) + return AVERROR_INVALIDDATA; - bytestream2_init(&s->stream_ptr, buf + 8, video_data_size); - s->decoding_map = buf + 8 + video_data_size; - s->skip_map = buf + 8 + video_data_size + s->decoding_map_size; + bytestream2_init(&s->stream_ptr, buf + 8, video_data_size); + s->decoding_map = buf + 8 + video_data_size; + s->skip_map = buf + 8 + video_data_size + s->decoding_map_size; - break; + break; - case 0x11: - if (! s->decoding_map_size) { - av_log(avctx, AV_LOG_ERROR, "Empty decoding map for format 0x11\n"); - return AVERROR_INVALIDDATA; - } + case 0x11: + if (! s->decoding_map_size) { + av_log(avctx, AV_LOG_ERROR, "Empty decoding map for format 0x11\n"); + return AVERROR_INVALIDDATA; + } - if (s->skip_map_size) { - av_log(avctx, AV_LOG_ERROR, "Skip map for format 0x11\n"); - return AVERROR_INVALIDDATA; - } + if (s->skip_map_size) { + av_log(avctx, AV_LOG_ERROR, "Skip map for format 0x11\n"); + return AVERROR_INVALIDDATA; + } - if (buf_size < 8 + video_data_size + s->decoding_map_size) - return AVERROR_INVALIDDATA; + if (buf_size < 8 + video_data_size + s->decoding_map_size) + return AVERROR_INVALIDDATA; - bytestream2_init(&s->stream_ptr, buf + 8, video_data_size); - s->decoding_map = buf + 8 + video_data_size; + bytestream2_init(&s->stream_ptr, buf + 8, video_data_size); + s->decoding_map = buf + 8 + video_data_size; - break; + break; - default: - av_log(avctx, AV_LOG_ERROR, "Frame type 0x%02X unsupported\n", frame_format); + default: + av_log(avctx, AV_LOG_ERROR, "Frame type 0x%02X unsupported\n", frame_format); } /* ensure we can't overread the packet */ @@ -1330,16 +1330,16 @@ static int ipvideo_decode_frame(AVCodecContext *avctx, } } - switch(frame_format) { - case 0x06: - ipvideo_decode_format_06_opcodes(s, frame); - break; - case 0x10: - ipvideo_decode_format_10_opcodes(s, frame); - break; - case 0x11: - ipvideo_decode_format_11_opcodes(s, frame); - break; + switch (frame_format) { + case 0x06: + ipvideo_decode_format_06_opcodes(s, frame); + break; + case 0x10: + ipvideo_decode_format_10_opcodes(s, frame); + break; + case 0x11: + ipvideo_decode_format_11_opcodes(s, frame); + break; } *got_frame = send_buffer;

1 0