r18312 - trunk/configure
Author: gb Date: Thu Apr 2 10:49:33 2009 New Revision: 18312 Log: Add VA API deps. Modified: trunk/configure Modified: trunk/configure ============================================================================== --- trunk/configure Thu Apr 2 10:48:06 2009 (r18311) +++ trunk/configure Thu Apr 2 10:49:33 2009 (r18312) @@ -1017,8 +1017,10 @@ flashsv_encoder_select="zlib" flv_encoder_select="aandct" h261_encoder_select="aandct" h263_encoder_select="aandct" +h263_vaapi_hwaccel_deps="va_va_h" h263p_encoder_select="aandct" h264_decoder_select="golomb" +h264_vaapi_hwaccel_deps="va_va_h" h264_vdpau_decoder_deps="vdpau_vdpau_h vdpau_vdpau_x11_h" imc_decoder_select="fft mdct" jpegls_decoder_select="golomb" @@ -1031,6 +1033,8 @@ mpeg2video_encoder_select="aandct" mpeg4_encoder_select="aandct" mpeg_vdpau_decoder_deps="vdpau_vdpau_h vdpau_vdpau_x11_h" mpeg1_vdpau_decoder_deps="vdpau_vdpau_h vdpau_vdpau_x11_h" +mpeg2_vaapi_hwaccel_deps="va_va_h" +mpeg4_vaapi_hwaccel_deps="va_va_h" mpeg_xvmc_decoder_deps="X11_extensions_XvMClib_h" msmpeg4v1_encoder_select="aandct" msmpeg4v2_encoder_select="aandct" @@ -1053,6 +1057,7 @@ svq3_decoder_suggest="zlib" tiff_decoder_suggest="zlib" tiff_encoder_suggest="zlib" tscc_decoder_select="zlib" +vc1_vaapi_hwaccel_deps="va_va_h" vc1_vdpau_decoder_deps="vdpau_vdpau_h vdpau_vdpau_x11_h" vorbis_decoder_select="fft mdct" vorbis_encoder_select="fft mdct" @@ -1062,6 +1067,7 @@ wmav2_decoder_select="fft mdct" wmav2_encoder_select="fft mdct" wmv1_encoder_select="aandct" wmv2_encoder_select="aandct" +wmv3_vaapi_hwaccel_deps="va_va_h" wmv3_vdpau_decoder_deps="vdpau_vdpau_h vdpau_vdpau_x11_h" zlib_decoder_select="zlib" zlib_encoder_select="zlib" @@ -2009,6 +2015,7 @@ for thread in $THREADS_LIST; do done check_lib math.h sin -lm +check_lib va/va.h vaInitialize -lva # test for C99 functions in math.h for func in llrint lrint lrintf round roundf truncf; do
Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:
On Thu, 2009-04-02 at 10:49 +0200, gb wrote:
Author: gb Date: Thu Apr 2 10:49:33 2009 New Revision: 18312
Log: Add VA API deps.
check_lib math.h sin -lm +check_lib va/va.h vaInitialize -lva
This adds a bogus dependency on libva even if vaapi support is disabled.
We link with --as-needed, so no there is no problem. -- M?ns Rullg?rd mans at mansr.com
On Mon, 2010-05-31 at 23:59 +0100, M?ns Rullg?rd wrote:
Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:
On Thu, 2009-04-02 at 10:49 +0200, gb wrote:
Author: gb Date: Thu Apr 2 10:49:33 2009 New Revision: 18312
Log: Add VA API deps.
check_lib math.h sin -lm +check_lib va/va.h vaInitialize -lva
This adds a bogus dependency on libva even if vaapi support is disabled.
We link with --as-needed, so no there is no problem.
There is a problem at least for creating static libraries. "-lva" is added to the list of flags that the _application_ must use when linking with the library. So any application would need to link with --as-needed too; and even if they did there would still be problems like the link failing if libva was removed from the system between creating the FFmpeg static libraries and linking the application. I think that adding completely irrelevant libraries and relying on --as-needed to remove them is not a good idea for the FFmpeg binaries either when it would be easy to avoid.
Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:
On Mon, 2010-05-31 at 23:59 +0100, M?ns Rullg?rd wrote:
Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:
On Thu, 2009-04-02 at 10:49 +0200, gb wrote:
Author: gb Date: Thu Apr 2 10:49:33 2009 New Revision: 18312
Log: Add VA API deps.
check_lib math.h sin -lm +check_lib va/va.h vaInitialize -lva
This adds a bogus dependency on libva even if vaapi support is disabled.
We link with --as-needed, so no there is no problem.
There is a problem at least for creating static libraries.
Static libraries don't have dependencies, so there can be no problem there.
"-lva" is added to the list of flags that the _application_ must use when linking with the library.
What list?
So any application would need to link with --as-needed too; and even if they did there would still be problems like the link failing if libva was removed from the system between creating the FFmpeg static libraries and linking the application. I think that adding completely irrelevant libraries and relying on --as-needed to remove them is not a good idea for the FFmpeg binaries either when it would be easy to avoid.
Just like listening to you is not a good idea when it would be easy to avoid. -- M?ns Rullg?rd mans at mansr.com
On Tue, 2010-06-01 at 13:18 +0100, M?ns Rullg?rd wrote:
Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:
On Mon, 2010-05-31 at 23:59 +0100, M?ns Rullg?rd wrote:
Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:
On Thu, 2009-04-02 at 10:49 +0200, gb wrote:
Author: gb Date: Thu Apr 2 10:49:33 2009 New Revision: 18312
Log: Add VA API deps.
check_lib math.h sin -lm +check_lib va/va.h vaInitialize -lva
This adds a bogus dependency on libva even if vaapi support is disabled.
We link with --as-needed, so no there is no problem.
There is a problem at least for creating static libraries.
Static libraries don't have dependencies, so there can be no problem there.
They do have a list of other libraries they depend on. What do you call that if not a "dependency"?
"-lva" is added to the list of flags that the _application_ must use when linking with the library.
What list?
The one in the .pc file. And if you want to turn this into another rant against pkg-config then please explain what _other_ part of installed FFmpeg files would indicate the flags required (such as whether the application needs to use -lva or not when linking against the static library), and why that would avoid the bogus dependency.
Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:
On Tue, 2010-06-01 at 13:18 +0100, M?ns Rullg?rd wrote:
Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:
On Mon, 2010-05-31 at 23:59 +0100, M?ns Rullg?rd wrote:
Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:
On Thu, 2009-04-02 at 10:49 +0200, gb wrote:
Author: gb Date: Thu Apr 2 10:49:33 2009 New Revision: 18312
Log: Add VA API deps.
check_lib math.h sin -lm +check_lib va/va.h vaInitialize -lva
This adds a bogus dependency on libva even if vaapi support is disabled.
We link with --as-needed, so no there is no problem.
There is a problem at least for creating static libraries.
Static libraries don't have dependencies, so there can be no problem there.
They do have a list of other libraries they depend on. What do you call that if not a "dependency"?
Where? -- M?ns Rullg?rd mans at mansr.com
On Tue, 2010-06-01 at 13:46 +0100, M?ns Rullg?rd wrote:
Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:
On Tue, 2010-06-01 at 13:18 +0100, M?ns Rullg?rd wrote:
Static libraries don't have dependencies, so there can be no problem there.
They do have a list of other libraries they depend on. What do you call that if not a "dependency"?
Where?
I see you're doing your best to avoid any kind of constructive discussion. Was it really too much to expect you to answer the second part of my mail, which was relevant to FFmpeg development? Anyway if you really need an explanation of this I can provide one: Traditionally extra flags required by static libraries have been either listed in the documentation of the library (in case they're constant and expected to stay that way for future versions), or communicated through various library-specific "xyz-config" binaries. Nowadays those have been mostly replaced by the use of .pc files. For FFmpeg libraries the information is AFAIK only available through the .pc file.
On Tue, Jun 01, 2010 at 01:18:13PM +0100, M?ns Rullg?rd wrote:
"-lva" is added to the list of flags that the _application_ must use when linking with the library.
What list?
Can we just cut the discussion short? Other uses of check_lib are done that way, so is there any reason not to do it as below, even if there is no other reason for simple consistency? Index: configure =================================================================== --- configure (revision 23256) +++ configure (working copy) @@ -2584,7 +2584,7 @@ done check_lib math.h sin -lm -check_lib va/va.h vaInitialize -lva +disabled vaapi || check_lib va/va.h vaInitialize -lva check_mathfunc exp2 check_mathfunc exp2f
Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
On Tue, Jun 01, 2010 at 01:18:13PM +0100, M?ns Rullg?rd wrote:
"-lva" is added to the list of flags that the _application_ must use when linking with the library.
What list?
Can we just cut the discussion short? Other uses of check_lib are done that way, so is there any reason not to do it as below, even if there is no other reason for simple consistency? Index: configure =================================================================== --- configure (revision 23256) +++ configure (working copy) @@ -2584,7 +2584,7 @@ done
check_lib math.h sin -lm -check_lib va/va.h vaInitialize -lva +disabled vaapi || check_lib va/va.h vaInitialize -lva
check_mathfunc exp2 check_mathfunc exp2f
OK -- M?ns Rullg?rd mans at mansr.com
participants (4)
-
mans＠mansr.com -
Reimar.Doeffinger＠gmx.de -
subversion＠mplayerhq.hu -
uoti.urpala＠pp1.inet.fi