On Thu, 17 Jan 2008 15:49:58 +0100 Baptiste Coudurier <baptiste.coudurier at smartjog.com> wrote:

Hi all,

Anders Gr?nberg wrote:

...

Modified: trunk/libavformat/rmdec.c ============================================================================== --- trunk/libavformat/rmdec.c (original) +++ trunk/libavformat/rmdec.c Thu Nov 15 22:04:06 2007 @@ -615,6 +615,7 @@ ff_rm_parse_packet (AVFormatContext *s, } } else av_get_packet(pb, pkt, len); + rm_ac3_swap_bytes(st, pkt);

} else av_get_packet(pb, pkt, len);

I think this is missing a pair of braces.

Sorry, this one got lost in the moderating queue for a very loong time. Is the report still valid ?

Yes, thanks. Fixed. The bug went unnoticed since rm_ac3_swap() does nothing when the codec is not dnet, so even if the function was called for all audio codecs there were no harmful effects. Ciao, Roberto -- Better is the enemy of good enough.