r24260 - in trunk/tests: fate2.mak ref/fate/msmpeg4v1
Author: vitor Date: Fri Jul 16 12:19:21 2010 New Revision: 24260 Log: Revert r24258: Log: Add msmpeg4v1 regtest Added: trunk/tests/ref/fate/msmpeg4v1 Modified: trunk/tests/fate2.mak According to Mans, "make test" tests already msmpeg4v1. Replaced: trunk/tests/fate2.mak - copied unchanged from r24257, trunk/tests/fate2.mak Deleted: trunk/tests/ref/fate/msmpeg4v1
vitor <subversion at mplayerhq.hu> writes:
Author: vitor Date: Fri Jul 16 12:19:21 2010 New Revision: 24260
Log: Revert r24258:
Log: Add msmpeg4v1 regtest
Added: trunk/tests/ref/fate/msmpeg4v1 Modified: trunk/tests/fate2.mak
According to Mans, "make test" tests already msmpeg4v1.
Don't believe anything I say. It was mislabeled, and is testing v3. What's worse, the encoder or decoder appears to be quite broken, so I can't add a proper test for it either: $ make regtest-msmpeg4v1 V=2 TEST VCODEC msmpeg4v1 /tmp/ffmpeg/ffmpeg -v 0 -y -flags +bitexact -dct fastint -idct simple -sws_flags +accurate_rnd+bitexact -qscale 10 -f image2 -vcodec pgmyuv -i /tmp/ffmpeg/tests/vsynth1/%02d.pgm -an -vcodec msmpeg4v1 /tmp/ffmpeg/./tests/data/vsynth1/msmpeg4v1.avi FFmpeg version git-svn-r24249, Copyright (c) 2000-2010 the FFmpeg developers built on Jul 16 2010 11:24:47 with gcc 4.3.5 configuration: --cpu=core2 --enable-gpl libavutil 50.22. 0 / 50.22. 0 libavcodec 52.83. 0 / 52.83. 0 libavformat 52.73. 0 / 52.73. 0 libavdevice 52. 2. 0 / 52. 2. 0 libavfilter 1.22. 0 / 1.22. 0 libswscale 0.11. 0 / 0.11. 0 Input #0, image2, from '/tmp/ffmpeg/tests/vsynth1/%02d.pgm': Duration: 00:00:02.00, start: 0.000000, bitrate: N/A Stream #0.0: Video: pgmyuv, yuv420p, 352x288, 25 fps, 25 tbr, 25 tbn, 25 tbc Output #0, avi, to '/tmp/ffmpeg/./tests/data/vsynth1/msmpeg4v1.avi': Stream #0.0: Video: msmpeg4v1, yuv420p, 352x288, q=2-31, 200 kb/s, 25 tbn, 25 tbc Stream mapping: Stream #0.0 -> #0.0 Press [q] to stop encoding frame= 50 fps= 0 q=10.0 Lsize= 7kB time=2.00 bitrate= 27.9kbits/s video:0kB audio:0kB global headers:0kB muxing overhead 10623.076923% /tmp/ffmpeg/ffmpeg -v 0 -y -flags +bitexact -dct fastint -idct simple -sws_flags +accurate_rnd+bitexact -i /tmp/ffmpeg/./tests/data/vsynth1/msmpeg4v1.avi -f rawvideo /tmp/ffmpeg/./tests/data/msmpeg4v1.vsynth1.out.yuv FFmpeg version git-svn-r24249, Copyright (c) 2000-2010 the FFmpeg developers built on Jul 16 2010 11:24:47 with gcc 4.3.5 configuration: --cpu=core2 --enable-gpl libavutil 50.22. 0 / 50.22. 0 libavcodec 52.83. 0 / 52.83. 0 libavformat 52.73. 0 / 52.73. 0 libavdevice 52. 2. 0 / 52. 2. 0 libavfilter 1.22. 0 / 1.22. 0 libswscale 0.11. 0 / 0.11. 0 Input #0, avi, from '/tmp/ffmpeg/./tests/data/vsynth1/msmpeg4v1.avi': Duration: 00:00:02.00, start: 0.000000, bitrate: 27 kb/s Stream #0.0: Video: msmpeg4v1, yuv420p, 352x288, 25 tbr, 25 tbn, 25 tbc Output #0, rawvideo, to '/tmp/ffmpeg/./tests/data/msmpeg4v1.vsynth1.out.yuv': Stream #0.0: Video: rawvideo, yuv420p, 352x288, q=2-31, 200 kb/s, 90k tbn, 25 tbc Stream mapping: Stream #0.0 -> #0.0 Press [q] to stop encoding [msmpeg4v1 @ 0x125b7c0] invalid startcode [msmpeg4v1 @ 0x125b7c0] header damaged Error while decoding stream #0.0 [msmpeg4v1 @ 0x125b7c0] invalid startcode [msmpeg4v1 @ 0x125b7c0] header damaged Error while decoding stream #0.0 [msmpeg4v1 @ 0x125b7c0] invalid startcode [msmpeg4v1 @ 0x125b7c0] header damaged Error while decoding stream #0.0 [msmpeg4v1 @ 0x125b7c0] invalid startcode [msmpeg4v1 @ 0x125b7c0] header damaged Error while decoding stream #0.0 [msmpeg4v1 @ 0x125b7c0] invalid startcode [msmpeg4v1 @ 0x125b7c0] header damaged Error while decoding stream #0.0 [msmpeg4v1 @ 0x125b7c0] invalid startcode [msmpeg4v1 @ 0x125b7c0] header damaged Error while decoding stream #0.0 -- M?ns Rullg?rd mans at mansr.com
On Fri, Jul 16, 2010 at 11:34:39AM +0100, M?ns Rullg?rd wrote:
vitor <subversion at mplayerhq.hu> writes:
Author: vitor Date: Fri Jul 16 12:19:21 2010 New Revision: 24260
Log: Revert r24258:
Log: Add msmpeg4v1 regtest
Added: trunk/tests/ref/fate/msmpeg4v1 Modified: trunk/tests/fate2.mak
According to Mans, "make test" tests already msmpeg4v1.
Don't believe anything I say. It was mislabeled, and is testing v3.
What's worse, the encoder or decoder appears to be quite broken, so I can't add a proper test for it either:
i dont want to break peoples dreams and hopes but i do not think we ever had a msmpeg4v1 encoder. I felt it would have been wasted time to write/ finish it. Supporting the later v2 and v3 seemed sufficient [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship naturally arises out of democracy, and the most aggravated form of tyranny and slavery out of the most extreme liberty. -- Plato
Michael Niedermayer <michaelni at gmx.at> writes:
On Fri, Jul 16, 2010 at 11:34:39AM +0100, M?ns Rullg?rd wrote:
vitor <subversion at mplayerhq.hu> writes:
Author: vitor Date: Fri Jul 16 12:19:21 2010 New Revision: 24260
Log: Revert r24258:
Log: Add msmpeg4v1 regtest
Added: trunk/tests/ref/fate/msmpeg4v1 Modified: trunk/tests/fate2.mak
According to Mans, "make test" tests already msmpeg4v1.
Don't believe anything I say. It was mislabeled, and is testing v3.
What's worse, the encoder or decoder appears to be quite broken, so I can't add a proper test for it either:
i dont want to break peoples dreams and hopes but i do not think we ever had a msmpeg4v1 encoder. I felt it would have been wasted time to write/ finish it. Supporting the later v2 and v3 seemed sufficient
So would you approve a patch to rip out the non-working encoder? We should either fix it or remove it. -- M?ns Rullg?rd mans at mansr.com
On Fri, Jul 16, 2010 at 03:39:54PM +0100, M?ns Rullg?rd wrote:
Michael Niedermayer <michaelni at gmx.at> writes:
On Fri, Jul 16, 2010 at 11:34:39AM +0100, M?ns Rullg?rd wrote:
vitor <subversion at mplayerhq.hu> writes:
Author: vitor Date: Fri Jul 16 12:19:21 2010 New Revision: 24260
Log: Revert r24258:
Log: Add msmpeg4v1 regtest
Added: trunk/tests/ref/fate/msmpeg4v1 Modified: trunk/tests/fate2.mak
According to Mans, "make test" tests already msmpeg4v1.
Don't believe anything I say. It was mislabeled, and is testing v3.
What's worse, the encoder or decoder appears to be quite broken, so I can't add a proper test for it either:
i dont want to break peoples dreams and hopes but i do not think we ever had a msmpeg4v1 encoder. I felt it would have been wasted time to write/ finish it. Supporting the later v2 and v3 seemed sufficient
So would you approve a patch to rip out the non-working encoder? We should either fix it or remove it.
iam ok with removing the struct [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong.
Michael Niedermayer <michaelni at gmx.at> writes:
On Fri, Jul 16, 2010 at 03:39:54PM +0100, M?ns Rullg?rd wrote:
Michael Niedermayer <michaelni at gmx.at> writes:
On Fri, Jul 16, 2010 at 11:34:39AM +0100, M?ns Rullg?rd wrote:
vitor <subversion at mplayerhq.hu> writes:
Author: vitor Date: Fri Jul 16 12:19:21 2010 New Revision: 24260
Log: Revert r24258:
Log: Add msmpeg4v1 regtest
Added: trunk/tests/ref/fate/msmpeg4v1 Modified: trunk/tests/fate2.mak
According to Mans, "make test" tests already msmpeg4v1.
Don't believe anything I say. It was mislabeled, and is testing v3.
What's worse, the encoder or decoder appears to be quite broken, so I can't add a proper test for it either:
i dont want to break peoples dreams and hopes but i do not think we ever had a msmpeg4v1 encoder. I felt it would have been wasted time to write/ finish it. Supporting the later v2 and v3 seemed sufficient
So would you approve a patch to rip out the non-working encoder? We should either fix it or remove it.
iam ok with removing the struct
And any code conditional on msmpeg4v1? I see no point keeping that either. -- M?ns Rullg?rd mans at mansr.com
On Fri, Jul 16, 2010 at 11:20:20PM +0100, M?ns Rullg?rd wrote:
Michael Niedermayer <michaelni at gmx.at> writes:
On Fri, Jul 16, 2010 at 03:39:54PM +0100, M?ns Rullg?rd wrote:
Michael Niedermayer <michaelni at gmx.at> writes:
On Fri, Jul 16, 2010 at 11:34:39AM +0100, M?ns Rullg?rd wrote:
vitor <subversion at mplayerhq.hu> writes:
Author: vitor Date: Fri Jul 16 12:19:21 2010 New Revision: 24260
Log: Revert r24258:
Log: Add msmpeg4v1 regtest
Added: trunk/tests/ref/fate/msmpeg4v1 Modified: trunk/tests/fate2.mak
According to Mans, "make test" tests already msmpeg4v1.
Don't believe anything I say. It was mislabeled, and is testing v3.
What's worse, the encoder or decoder appears to be quite broken, so I can't add a proper test for it either:
i dont want to break peoples dreams and hopes but i do not think we ever had a msmpeg4v1 encoder. I felt it would have been wasted time to write/ finish it. Supporting the later v2 and v3 seemed sufficient
So would you approve a patch to rip out the non-working encoder? We should either fix it or remove it.
iam ok with removing the struct
And any code conditional on msmpeg4v1? I see no point keeping that either.
that code would be quite helpfull to someone who wanted to finish the encoder and someone who wanted to do this likely would not find it if its just in a distant past revission we also could leave the struct and mark it with CODEC_CAP_EXPERIMENTAL [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible, but not simpler. -- Albert Einstein
Michael Niedermayer <michaelni at gmx.at> writes:
On Fri, Jul 16, 2010 at 11:20:20PM +0100, M?ns Rullg?rd wrote:
Michael Niedermayer <michaelni at gmx.at> writes:
On Fri, Jul 16, 2010 at 03:39:54PM +0100, M?ns Rullg?rd wrote:
Michael Niedermayer <michaelni at gmx.at> writes:
On Fri, Jul 16, 2010 at 11:34:39AM +0100, M?ns Rullg?rd wrote:
vitor <subversion at mplayerhq.hu> writes:
> Author: vitor > Date: Fri Jul 16 12:19:21 2010 > New Revision: 24260 > > Log: > Revert r24258: > > Log: > Add msmpeg4v1 regtest > > Added: > trunk/tests/ref/fate/msmpeg4v1 > Modified: > trunk/tests/fate2.mak > > According to Mans, "make test" tests already msmpeg4v1.
Don't believe anything I say. It was mislabeled, and is testing v3.
What's worse, the encoder or decoder appears to be quite broken, so I can't add a proper test for it either:
i dont want to break peoples dreams and hopes but i do not think we ever had a msmpeg4v1 encoder. I felt it would have been wasted time to write/ finish it. Supporting the later v2 and v3 seemed sufficient
So would you approve a patch to rip out the non-working encoder? We should either fix it or remove it.
iam ok with removing the struct
And any code conditional on msmpeg4v1? I see no point keeping that either.
that code would be quite helpfull to someone who wanted to finish the encoder and someone who wanted to do this likely would not find it if its just in a distant past revission
Do you honestly think anyone will ever do that?
we also could leave the struct and mark it with CODEC_CAP_EXPERIMENTAL
The code is sprinkled with if(s->msmpeg4_version==1) making all the working encoders slower for no good reason. -- M?ns Rullg?rd mans at mansr.com
On Sat, Jul 17, 2010 at 08:39:40PM +0100, M?ns Rullg?rd wrote:
Michael Niedermayer <michaelni at gmx.at> writes:
And any code conditional on msmpeg4v1? I see no point keeping that either.
that code would be quite helpfull to someone who wanted to finish the encoder and someone who wanted to do this likely would not find it if its just in a distant past revission
Do you honestly think anyone will ever do that?
we also could leave the struct and mark it with CODEC_CAP_EXPERIMENTAL
The code is sprinkled with if(s->msmpeg4_version==1) making all the working encoders slower for no good reason.
Given that we never had a working encoder few people will know for sure if they are correct or not anyway. Maybe there's a volunteer to replace those if (...) by comments that say what we know, and what we suspect, needs to be done for v1 and why?
On Sat, Jul 17, 2010 at 08:39:40PM +0100, M?ns Rullg?rd wrote:
Michael Niedermayer <michaelni at gmx.at> writes:
On Fri, Jul 16, 2010 at 11:20:20PM +0100, M?ns Rullg?rd wrote:
Michael Niedermayer <michaelni at gmx.at> writes:
On Fri, Jul 16, 2010 at 03:39:54PM +0100, M?ns Rullg?rd wrote:
Michael Niedermayer <michaelni at gmx.at> writes:
On Fri, Jul 16, 2010 at 11:34:39AM +0100, M?ns Rullg?rd wrote: > vitor <subversion at mplayerhq.hu> writes: > > > Author: vitor > > Date: Fri Jul 16 12:19:21 2010 > > New Revision: 24260 > > > > Log: > > Revert r24258: > > > > Log: > > Add msmpeg4v1 regtest > > > > Added: > > trunk/tests/ref/fate/msmpeg4v1 > > Modified: > > trunk/tests/fate2.mak > > > > According to Mans, "make test" tests already msmpeg4v1. > > Don't believe anything I say. It was mislabeled, and is testing v3. > > What's worse, the encoder or decoder appears to be quite broken, so I > can't add a proper test for it either:
i dont want to break peoples dreams and hopes but i do not think we ever had a msmpeg4v1 encoder. I felt it would have been wasted time to write/ finish it. Supporting the later v2 and v3 seemed sufficient
So would you approve a patch to rip out the non-working encoder? We should either fix it or remove it.
iam ok with removing the struct
And any code conditional on msmpeg4v1? I see no point keeping that either.
that code would be quite helpfull to someone who wanted to finish the encoder and someone who wanted to do this likely would not find it if its just in a distant past revission
Do you honestly think anyone will ever do that?
did you honestly think anyone would write a msmpeg4v2 encoder?
we also could leave the struct and mark it with CODEC_CAP_EXPERIMENTAL
The code is sprinkled with if(s->msmpeg4_version==1) making all the working encoders slower for no good reason.
adding CONFIG_MSMPEG4V1_ENCODER && in them would be as easy as removing them [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The real ebay dictionary, page 1 "Used only once" - "Some unspecified defect prevented a second use" "In good condition" - "Can be repaird by experienced expert" "As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
vitor <subversion <at> mplayerhq.hu> writes:
Log: Revert r24258:
Log: Add msmpeg4v1 regtest
Added: trunk/tests/ref/fate/msmpeg4v1 Modified: trunk/tests/fate2.mak
According to Mans, "make test" tests already msmpeg4v1.
No. Note that the encoder was broken since the beginning of time, iirc, I tested ~r379, ~r643 and ~r1724 (not everything compiles, so I sometimes incremented the version). Carl Eugen
vitor <subversion <at> mplayerhq.hu> writes:
Author: vitor Date: Fri Jul 16 12:19:21 2010 New Revision: 24260
Log: Revert r24258:
Could you please revert this patch: This is the only msmpeg4v1 test we have. Carl Eugen
participants (6)
-
cehoyos@ag.or.at -
mans@mansr.com -
michaelni@gmx.at -
Reimar.Doeffinger@gmx.de -
subversion@mplayerhq.hu -
vitor1001@gmail.com