April 2007 - ffmpeg-devel - lists.ffmpeg.org

[FWD] [PATCH] immediate decoding of dvd stills
by nicola_sabbi＠fastwebnet.it 24 Jun '11

24 Jun '11

Some time ago someone posted this small patch to permit decoding dvd still images without setting LOW_DELAY; unfortunately it seems the patch was forgotten Is it ok to commit? If not, what's the right way to proceed?

5 17

[PATCH] Apple Video Encoder (rpza)
by ffmpeg.php＠gmail.com 24 Jan '11

24 Jan '11

Attached is a patch to add support for Apple Video encoding (rpza). The quality settings are defined at compile time right now since I wasn't really sure how to map ffmpeg's numerous video options to the capabilities of rpza. It supports all rpza encoding opcodes but the 4-color block encoding doesn't try to do multiblock runs yet. -Todd

9 20

[PATCH] GSM-MS decoder and encoder
by mbardiaux＠mediaxim.be 01 Feb '10

01 Feb '10

-- Michel Bardiaux R&D Director T +32 [0] 2 790 29 41 F +32 [0] 2 790 29 02 E mailto:mbardiaux at mediaxim.be Mediaxim NV/SA Vorstlaan 191 Boulevard du Souverain Brussel 1160 Bruxelles http://www.mediaxim.com/

6 56

compressed v4l2 images
by ramiro＠lisha.ufsc.br 10 Dec '09

10 Dec '09

Hello, I have a webcam running the zc0301 driver. On the VIDIOC_S_FMT ioctl call, it always sets the pixel format to V4L2_PIX_FMT_JPEG. The current code doesn't take into account when the pixel format is changed on that call. Also, it doesn't support the compressed JPEG stream even if the pixel format is changed according to the result of the ioctl. What's the best way to make it support compressed JPEG? Just check for compressed and set appropriate codec_id? Ramiro Polla

6 16

[PATCH] DV timecode
by baptiste.coudurier＠smartjog.com 02 Feb '09

02 Feb '09

Hi 3 patches: - add timecode.h to avoid code duplication for drop frame timecode adjustment - use new lavc timecode api to set timecode in DV. Regression tests change because now default behaviour is non drop frame timecode, you can still activate it by using -flags2 +drop_frame_timecode - timecode helper function for ffmpeg to set timecode. Maybe moving brktimegm to lavu and using it is better ? -- Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA SMARTJOG S.A. http://www.smartjog.com Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA Phone: +33 1 49966312

5 14

[RFC] ratecontrol buffer size magic
by baptiste.coudurier＠smartjog.com 29 Nov '08

29 Nov '08

Hi, I stumbed accross a weird behaviour of the CBR ratecontrol lately, basically doing: ffmpeg -i file.mpg -vcodec mpeg2video -minrate 30000k -maxrate 30000k -b 30000k -intra -flags +ildct+low_delay -dc 10 -flags2 +ivlc+non_linear_q -ps 1 -qmin 1 -qmax 12 -top 1 -vglobal 4 -acodec pcm_s16be -f mov -bufsize 1200000 -rc_init_occupancy 1200000 cbr.mov Constraints are so in order to achieve vbv delay as 3600. Now ffmpeg will only give me qp as 24. While tweaking I changed some magic in ratecontrol.c (see patch attached) and now qp have decent/good values. I dig into svn history and found out that r2601 bumped */2 to */3 to improve CBR ratecontrol. Can anyone explain in detail why that magic does improve behaviour ? Can that parameter be user setable ? Or is it really hardcoded everywhere ? Am I doing something terribly wrong ? Thanks for comments. -- Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA SMARTJOG S.A. http://www.smartjog.com Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA Phone: +33 1 49966312

4 19

[PATCH] CYUV encoder resurrected
by baptiste.coudurier＠smartjog.com 10 Sep '08

10 Sep '08

Hi Here is old cyuv encoder resurrected from [Ffmpeg-devel] Trellis Quantization Applied To (A)DPCM http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2006-June/011688.html by Loren. I added some #ifdef DEBUG around printf code, renamed some macros. Can it be applied ? -- Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA SMARTJOG S.A. http://www.smartjog.com Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA Phone: +33 1 49966312

4 9

Duplicate options
by roine＠users.sourceforge.net 08 Aug '08

08 Aug '08

ffmpeg lists some options twice in the help: -threads -strict -dc -qdiff -rc_eq -aspect The subtitle options are also both in the Main section and the Subtitle section: -scodec -slang -newsubtitle It seems the duplication is due to some options being in ffmpeg.c and some in libavcodec/utils.c. I don't really understand the difference (so no patch from me), but my guess is they should be removed from ffmpeg.c. Roine

4 3

crash with H.264 MBAFF of height 676 or more
by takuma＠stream.st 23 Jul '08

23 Jul '08

I am trying to trancecode from H.264 MBAF (encoded with x.264) to flv. It seems that MBAFF H.264 of height 676 or more crashes ffmpeg. FFmpeg said "[h264 @ 0x6da784]concealing 860 DC, 860 AC, 860 MV errors" many times and crashed with SIGABRT. ffdshow and VLC also crashes. I think this is maybe a libavcodec's bug because I asked CoreAVC users whether it crashed, and they said No. Sample File: I uploaded to /MPlayer/incoming/h264_MBAFF_height676 My environment: CPU: Pentium3 (Coppermine) OS: Fedora Core 5 kernel: 2.6.18-1.2257.fc5 glibc: 2.4-11 GDB: GNU gdb Red Hat Linux (6.3.0.0-1.134.fc5rh) (ffdshow and VLC is on Windows XP SP2) Command: /home/user1/ffmpeg-b/ffmpeg_g -i test.mp4 -y -vcodec flv -qscale 16 -me full ./test.flv Output: FFmpeg version SVN-r8268, Copyright (c) 2000-2007 Fabrice Bellard, et al. configuration: --enable-pp --enable-liba52 --enable-libfaad --enable-libmp3lame --enable-libogg --enable-libvorbis --enable-gpl --cpu=pentium3 --disable-audio-oss --disable-audio-beos --disable-v4l --disable-v4l2 --disable-bktr --disable-dv1394 --disable-network --disable-ipv6 --enable-shared libavutil version: 49.3.0 libavcodec version: 51.38.0 libavformat version: 51.10.0 built on Mar 6 2007 15:33:42, gcc: 4.1.1 20070105 (Red Hat 4.1.1-51) Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'files/ppfx00353.mp4': Duration: 00:00:03.3, start: 0.000000, bitrate: 45 kb/s Stream #0.0(und): Video: h264, yuv420p, 320x688, 29.97 fps(r) Output #0, flv, to './movie_thumbnail_tmp_d2kMDX.flv': Stream #0.0: Video: flv, yuv420p, 320x688, q=2-31, 200 kb/s, 29.97 fps(c) Stream mapping: Stream #0.0 -> #0.0 Press [q] to stop encoding [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors2kbits/s [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors9kbits/s [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors5kbits/s [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors3kbits/s [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors2kbits/s [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors7kbits/s [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors [h264 @ 0xf0e784]concealing 860 DC, 860 AC, 860 MV errors frame= 100 q=16.0 Lsize= 62kB time=3.3 bitrate= 152.9kbits/s video:61kB audio:0kB global headers:0kB muxing overhead 2.881793% *** glibc detected *** /home/user1/ffmpeg-b/ffmpeg_g: corrupted double-linked list: 0x08206e68 *** ======= Backtrace: ========= /lib/libc.so.6[0x85fe9f] /lib/libc.so.6[0x8617ae] /lib/libc.so.6(__libc_free+0x78)[0x864f6f] /usr/local/lib/libavutil.so.49(av_freep+0x16)[0xc30316] ======= Memory map: ======== 00101000-0010c000 r-xp 00000000 21:01 11877613 /usr/lib/liba52.so.0.0.0 0010c000-0010d000 rwxp 0000a000 21:01 11877613 /usr/lib/liba52.so.0.0.0 0010d000-0010e000 rwxp 0010d000 00:00 0 00110000-0018a000 r-xp 00000000 21:01 117525 /usr/local/lib/libavformat.so.51.10.0 0018a000-0018d000 rwxp 00079000 21:01 117525 /usr/local/lib/libavformat.so.51.10.0 0018d000-00582000 r-xp 00000000 21:01 117521 /usr/local/lib/libavcodec.so.51.38.0 00582000-00588000 rwxp 003f4000 21:01 117521 /usr/local/lib/libavcodec.so.51.38.0 00588000-005f0000 rwxp 00588000 00:00 0 005f0000-00631000 r-xp 00000000 21:01 11877611 /usr/lib/libmp3lame.so.0.0.0 00631000-00633000 rwxp 00041000 21:01 11877611 /usr/lib/libmp3lame.so.0.0.0 00633000-00664000 rwxp 00633000 00:00 0 00664000-0066f000 r-xp 00000000 21:01 527255 /usr/lib/libvorbisenc.so.2.0.2 0066f000-0075e000 rwxp 0000a000 21:01 527255 /usr/lib/libvorbisenc.so.2.0.2 0075e000-00760000 rwxp 0075e000 00:00 0 00760000-007a3000 r-xp 00000000 21:01 11877621 /usr/lib/libfaad.so.0.0.0 007a3000-007a6000 rwxp 00042000 21:01 11877621 /usr/lib/libfaad.so.0.0.0 007a6000-007b1000 r-xp 00000000 21:01 48998 /lib/libgcc_s-4.1.1-20070108.so.1 007b1000-007b2000 rwxp 0000a000 21:01 48998 /lib/libgcc_s-4.1.1-20070108.so.1 007e1000-007fa000 r-xp 00000000 21:01 53449 /lib/ld-2.4.so 007fa000-007fb000 r-xp 00018000 21:01 53449 /lib/ld-2.4.so 007fb000-007fc000 rwxp 00019000 21:01 53449 /lib/ld-2.4.so 007fe000-0092b000 r-xp 00000000 21:01 53450 /lib/libc-2.4.so 0092b000-0092d000 r-xp 0012d000 21:01 53450 /lib/libc-2.4.so 0092d000-0092e000 rwxp 0012f000 21:01 53450 /lib/libc-2.4.so 0092e000-00931000 rwxp 0092e000 00:00 0 00933000-00935000 r-xp 00000000 21:01 51558 /lib/libdl-2.4.so 00935000-00936000 r-xp 00001000 21:01 51558 /lib/libdl-2.4.so 00936000-00937000 rwxp 00002000 21:01 51558 /lib/libdl-2.4.so 00939000-0095c000 r-xp 00000000 21:01 53451 /lib/libm-2.4.so 0095c000-0095d000 r-xp 00022000 21:01 53451 /lib/libm-2.4.so 0095d000-0095e000 rwxp 00023000 21:01 53451 /lib/libm-2.4.so 00960000-00973000 r-xp 00000000 21:01 527456 /usr/lib/libz.so.1.2.3 00973000-00974000 rwxp 00012000 21:01 527456 /usr/lib/libz.so.1.2.3 00976000-0097b000 r-xp 00000000 21:01 526209 /usr/lib/libogg.so.0.5.3 0097b000-0097c000 rwxp 00004000 21:01 526209 /usr/lib/libogg.so.0.5.3 00ae0000-00ae1000 r-xp 00ae0000 00:00 0 [vdso] 00c2c000-00c33000 r-xp 00000000 21:01 113560 /usr/local/lib/libavutil.so.49.3.0 00c33000-00c34000 rwxp 00006000 21:01 113560 /usr/local/lib/libavutil.so.49.3.0 00c34000-00c36000 rwxp 00c34000 00:00 0 00d90000-00dac000 r-xp 00000000 21:01 520954 /usr/lib/libvorbis.so.0.3.1 00dac000-00dba000 rwxp 0001c000 21:01 520954 /usr/lib/libvorbis.so.0.3.1 08048000-08058000 r-xp 00000000 22:01 17367411 /home/user1/ffmpeg-b/ffmpeg_g 08058000-08059000 rw-p 0000f000 22:01 17367411 /home/user1/ffmpeg-b/ffmpeg_g 08059000-0805a000 rw-p 08059000 00:00 0 081a9000-0836e000 rw-p 081a9000 00:00 0 b7b00000-b7b21000 rw-p b7b00000 00:00 0 b7b21000-b7c00000 ---p b7b21000 00:00 0 b7cf5000-b7fa8000 rw-p b7cf5000 00:00 0 bf963000-bf978000 rwxp bf963000 00:00 0 [stack] ???????? GDB: (gdb) backtrace #0 0x00bab402 in __kernel_vsyscall () #1 0x00825ee9 in raise () from /lib/libc.so.6 #2 0x008274f1 in abort () from /lib/libc.so.6 #3 0x0085a53b in __libc_message () from /lib/libc.so.6 #4 0x0085fe9f in malloc_consolidate () from /lib/libc.so.6 #5 0x008617ae in _int_free () from /lib/libc.so.6 #6 0x00864f6f in free () from /lib/libc.so.6 #7 0x00cdf316 in av_freep () from /usr/local/lib/libavutil.so.49 (gdb) disass $pc-32 $pc+32 Dump of assembler code from 0xbab3e2 to 0xbab422: 0x00bab3e2: add %al,(%eax) 0x00bab3e4: add %al,(%eax) 0x00bab3e6: add %al,(%eax) 0x00bab3e8: add %al,(%eax) 0x00bab3ea: add %al,(%eax) 0x00bab3ec: add %al,(%eax) 0x00bab3ee: add %al,(%eax) 0x00bab3f0: add %al,(%eax) 0x00bab3f2: add %al,(%eax) 0x00bab3f4: add %al,(%eax) 0x00bab3f6: add %al,(%eax) 0x00bab3f8: add %al,(%eax) 0x00bab3fa: add %al,(%eax) 0x00bab3fc: add %al,(%eax) 0x00bab3fe: add %al,(%eax) 0x00bab400 <__kernel_vsyscall+0>: int $0x80 0x00bab402 <__kernel_vsyscall+2>: ret 0x00bab403 <__kernel_vsyscall+3>: nop 0x00bab404 <__kernel_vsyscall+4>: nop 0x00bab405 <__kernel_vsyscall+5>: nop 0x00bab406 <__kernel_vsyscall+6>: nop 0x00bab407 <__kernel_vsyscall+7>: nop 0x00bab408 <__kernel_vsyscall+8>: nop 0x00bab409 <__kernel_vsyscall+9>: nop 0x00bab40a <__kernel_vsyscall+10>: nop 0x00bab40b <__kernel_vsyscall+11>: nop 0x00bab40c <__kernel_vsyscall+12>: nop 0x00bab40d <__kernel_vsyscall+13>: nop 0x00bab40e <__kernel_vsyscall+14>: nop 0x00bab40f <__kernel_vsyscall+15>: nop 0x00bab410 <__kernel_vsyscall+16>: nop 0x00bab411 <__kernel_vsyscall+17>: nop 0x00bab412 <__kernel_vsyscall+18>: nop 0x00bab413 <__kernel_vsyscall+19>: nop 0x00bab414 <__kernel_vsyscall+20>: nop 0x00bab415 <__kernel_vsyscall+21>: nop 0x00bab416 <__kernel_vsyscall+22>: nop 0x00bab417 <__kernel_vsyscall+23>: nop 0x00bab418 <__kernel_vsyscall+24>: nop 0x00bab419 <__kernel_vsyscall+25>: nop 0x00bab41a <__kernel_vsyscall+26>: nop 0x00bab41b <__kernel_vsyscall+27>: nop 0x00bab41c <__kernel_vsyscall+28>: nop 0x00bab41d <__kernel_vsyscall+29>: nop 0x00bab41e <__kernel_vsyscall+30>: nop 0x00bab41f <__kernel_vsyscall+31>: nop 0x00bab420 <__kernel_sigreturn+0>: pop %eax 0x00bab421 <__kernel_sigreturn+1>: mov $0x77,%eax End of assembler dump. (gdb) info all-registers eax 0x0 0 ecx 0x5827 22567 edx 0x6 6 ebx 0x5827 22567 esp 0xbf9cf438 0xbf9cf438 ebp 0xbf9cf444 0xbf9cf444 esi 0xbf9cf4e4 -1080232732 edi 0x92cff4 9621492 eip 0xbab402 0xbab402 eflags 0x246 582 cs 0x73 115 ss 0x7b 123 ds 0x7b 123 es 0x7b 123 fs 0x0 0 gs 0x33 51 st0 -nan(0x8080808080808080) (raw 0xffff8080808080808080) st1 -nan(0x8080808080808080) (raw 0xffff8080808080808080) st2 -nan(0x8080808080808080) (raw 0xffff8080808080808080) st3 30000 (raw 0x400dea60000000000000) st4 0.033366666666666666666457054246652802 (raw 0x3ffa88ab7c61c2038cc4) st5 0 (raw 0x00000000000000000000) st6 62010 (raw 0x400ef23a000000000000) st7 2.881793259151749886370907915988937 (raw 0x4000b86f4cfe78f61000) fctrl 0x37f 895 fstat 0x20 32 ftag 0xffff 65535 fiseg 0x73 115 fioff 0x83ce63 8638051 foseg 0x7b 123 fooff 0xbf9cca04 -1080243708 fop 0x55c 1372 xmm0 {v4_float = {0xaae60, 0x0, 0x0, 0x0}, v2_double = {0x0, 0x0}, v16_int8 = {0x0, 0xe6, 0x2a, 0x49, 0x0 <repeats 12 times>}, v8_int16 = {0xe600, 0x492a, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, v4_int32 = {0x492ae600, 0x0, 0x0, 0x0}, v2_int64 = {0x492ae600, 0x0}, uint128 = 0x000000000000000000000000492ae600} xmm1 {v4_float = {0x0, 0x0, 0x0, 0x0}, v2_double = {0x0, 0x0}, v16_int8 = {0x0 <repeats 16 times>}, v8_int16 = {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, v4_int32 = {0x0, 0x0, 0x0, 0x0}, v2_int64 = {0x0, 0x0}, uint128 = 0x00000000000000000000000000000000} xmm2 {v4_float = {0x0, 0x0, 0x0, 0x0}, v2_double = {0x0, 0x0}, v16_int8 = {0x0 <repeats 16 times>}, v8_int16 = {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, v4_int32 = {0x0, 0x0, 0x0, 0x0}, v2_int64 = {0x0, 0x0}, uint128 = 0x00000000000000000000000000000000} xmm3 {v4_float = {0x0, 0x0, 0x0, 0x0}, v2_double = {0x0, 0x0}, v16_int8 = {0x0 <repeats 16 times>}, v8_int16 = {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, v4_int32 = {0x0, 0x0, 0x0, 0x0}, v2_int64 = {0x0, 0x0}, uint128 = 0x00000000000000000000000000000000} xmm4 {v4_float = {0x0, 0x0, 0x0, 0x0}, v2_double = {0x0, 0x0}, v16_int8 = {0x0 <repeats 16 times>}, v8_int16 = {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, v4_int32 = {0x0, 0x0, 0x0, 0x0}, v2_int64 = {0x0, 0x0}, uint128 = 0x00000000000000000000000000000000} xmm5 {v4_float = {0x0, 0x0, 0x0, 0x0}, v2_double = {0x0, 0x0}, v16_int8 = {0x0 <repeats 16 times>}, v8_int16 = {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, v4_int32 = {0x0, 0x0, 0x0, 0x0}, v2_int64 = {0x0, 0x0}, uint128 = 0x00000000000000000000000000000000} xmm6 {v4_float = {0x0, 0x0, 0x0, 0x0}, v2_double = {0x0, 0x0}, v16_int8 = {0x0 <repeats 16 times>}, v8_int16 = {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, v4_int32 = {0x0, 0x0, 0x0, 0x0}, v2_int64 = {0x0, 0x0}, uint128 = 0x00000000000000000000000000000000} xmm7 {v4_float = {0x0, 0x0, 0x0, 0x0}, v2_double = {0x0, 0x0}, v16_int8 = {0x0 <repeats 16 times>}, v8_int16 = {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}, v4_int32 = {0x0, 0x0, 0x0, 0x0}, v2_int64 = {0x0, 0x0}, uint128 = 0x00000000000000000000000000000000} mxcsr 0x1f80 8064 mm0 {uint64 = 0x8080808080808080, v2_int32 = {0x80808080, 0x80808080}, v4_int16 = {0x8080, 0x8080, 0x8080, 0x8080}, v8_int8 = {0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80}} mm1 {uint64 = 0x8080808080808080, v2_int32 = {0x80808080, 0x80808080}, v4_int16 = {0x8080, 0x8080, 0x8080, 0x8080}, v8_int8 = {0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80}} mm2 {uint64 = 0x8080808080808080, v2_int32 = {0x80808080, 0x80808080}, v4_int16 = {0x8080, 0x8080, 0x8080, 0x8080}, v8_int8 = {0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80, 0x80}} mm3 {uint64 = 0xea60000000000000, v2_int32 = {0x0, 0xea600000}, v4_int16 = {0x0, 0x0, 0x0, 0xea60}, v8_int8 = {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x60, 0xea}} mm4 {uint64 = 0x88ab7c61c2038cc4, v2_int32 = {0xc2038cc4, 0x88ab7c61}, v4_int16 = {0x8cc4, 0xc203, 0x7c61, 0x88ab}, v8_int8 = {0xc4, 0x8c, 0x3, 0xc2, 0x61, 0x7c, 0xab, 0x88}} mm5 {uint64 = 0x0, v2_int32 = {0x0, 0x0}, v4_int16 = {0x0, 0x0, 0x0, 0x0}, v8_int8 = {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0}} mm6 {uint64 = 0xf23a000000000000, v2_int32 = {0x0, 0xf23a0000}, v4_int16 = {0x0, 0x0, 0x0, 0xf23a}, v8_int8 = {0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x3a, 0xf2}} mm7 {uint64 = 0xb86f4cfe78f61000, v2_int32 = {0x78f61000, 0xb86f4cfe}, v4_int16 = {0x1000, 0x78f6, 0x4cfe, 0xb86f}, v8_int8 = {0x0, 0x10, 0xf6, 0x78, 0xfe, 0x4c, 0x6f, 0xb8}}

3 3

[PATCH] ported SGI decoder to the new API
by sunxiaohui＠dsp.ac.cn 30 Mar '08

30 Mar '08

Xiaohui Sun wrote: patch updated. > Hi > > On Thu, Apr 05, 2007 at 09:42:59AM +0800, Xiaohui Sun wrote: > [...] > > > + * @param out_ptr output buffer > > this pointer does not point to the output buffer but rather to the line > after the output buffer done > > > > + * @param in_buf input buffer > > + * @param end_buf end of input buffer > > + * @param s the current image state > > + * @return 0 if no error, else return error number > > + */ > > +static int read_rle_sgi(unsigned char* out_ptr, uint8_t *in_buf, > > + uint8_t *end_buf, SgiState* s) > > s/end_buf/in_end/ done > > > > +{ > > + uint8_t *dest_row = out_ptr; > > + unsigned int len = s->height * s->depth * 4; > > + uint8_t *start_table = in_buf; > > + unsigned int y, z; > > + unsigned int start_offset; > > + > > + /* size of RLE offset and length tables */ > > + if(len * 2 > end_buf - in_buf) { > > + return AVERROR_INVALIDDATA; > > + } > > + > > + in_buf -= SGI_HEADER_SIZE; > > + for (z = 0; z < s->depth; z++) { > > + for (y = 0; y < s->height; y++) { > > + dest_row -= s->linesize; > > + start_offset = bytestream_get_be32(&start_table); > > + if(start_offset > end_buf - in_buf) { > > + return AVERROR_INVALIDDATA; > > + } > > + if (expand_rle_row(in_buf + start_offset, end_buf, > dest_row + z, > > + dest_row + FFABS(s->linesize), s->depth) != s->width) > > + return AVERROR_INVALIDDATA; > > + } > > > + dest_row = out_ptr; > > if you move this line before the for() then you avoid the second such > assignment above done > > > > + } > > + return 0; > > +} > > + > > +/** > > + * read an uncompressed SGI image > > + * @param out_ptr output buffer > > > + * @param end_ptr end ofoutput buffer > > typo also s/end_ptr/out_end/ done > > > > + * @param in_buf input buffer > > > + * @param end_buf end of input buffer > > s/end_buf/in_end/ > done > > [...] > > + uint8_t *dest_row = end_ptr; > > this is uneeded > done > > > + uint8_t *ptr = in_buf; > > + unsigned int offset = s->height * s->width; > > + > > + /* test buffer size */ > > + if (offset * s->depth > end_buf - in_buf) { > > + return -1; > > + } > > + > > + for (y = s->height - 1; y >= 0; y--) { > > > + dest_row = out_ptr + (y * FFABS(s->linesize)); > > this looks wrong changed > > > > + for (x = s->width; x > 0; x--) { > > + for(z = 0; z < s->depth; z ++) { > > + bytestream_put_byte(&dest_row, *ptr); > > + ptr += offset; > > + } > > > + ptr = ++in_buf; > > if you move this assignment before the for loop then you avoid the second > redundant assignment farther above done > > > [...] > > + dimension = bytestream_get_be16(&in_buf); > > + s->width = bytestream_get_be16(&in_buf); > > + s->height = bytestream_get_be16(&in_buf); > > + s->depth = bytestream_get_be16(&in_buf); > > these could be verticall aligned like > > dimension = bytestream_get_be16(&in_buf); > s->width = bytestream_get_be16(&in_buf); > s->height = bytestream_get_be16(&in_buf); > s->depth = bytestream_get_be16(&in_buf); > > looks nicer ... (not really important though) changed > > > [...] > > + /* name */ > > + memset(buf, 0, 80); > > + buf += 80; > > + > > + /* colormap */ > > + bytestream_put_be32(&buf, 0L); > > + > > + /* the rest of the 512 byte header is unused */ > > + memset(buf, 0, 404); > > + buf += 404; > > thats just a single memset() ... > > > [...] > > + if((length = ff_rle_encode(buf, end_buf - buf - 1, > encode_buf, 1, width, 0, 0, 0x80, 0)) == -1) { > > if(... < 1) > done > > [...]

4 16