October 2009 - ffmpeg-devel - lists.ffmpeg.org

[PATCH] Implement libavcodec/opt.[ch] generic options handling
by stefano.sabatini-lala＠poste.it 10 Sep '10

10 Sep '10

Hi all, this is my first attempt to move the option handling code from the applications to the library, it also should make possible to remove the deprecated lavf AVFormatParameters. Please comment. Regards. -- FFmpeg = Furious Faboulous Majestic Picky Encoding/decoding Gangster

2 12

[PATCH] g722 decoder, no licensing fame
by kenan.gillet＠gmail.com 10 Sep '10

10 Sep '10

On Wed, Mar 25, 2009 at 2:39 PM, Michael Niedermayer <michaelni at gmx.at> wrote: > On Wed, Mar 25, 2009 at 09:57:51AM -0700, Kenan Gillet wrote: >> Hi, >> >> On Mar 21, 2009, at 1:34 PM, Michael Niedermayer wrote: >> >>> On Sat, Mar 21, 2009 at 12:43:35AM -0700, Kenan Gillet wrote: > [...] >>> >>> >>>> @@ -2819,6 +2822,7 @@ >>>> memset(ap, 0, sizeof(*ap)); >>>> ap->prealloced_context = 1; >>>> ap->sample_rate = audio_sample_rate; >>>> + ap->bit_rate = audio_bit_rate; >>>> ap->channels = audio_channels; >>>> ap->time_base.den = frame_rate.num; >>>> ap->time_base.num = frame_rate.den; >>>> @@ -2892,6 +2896,7 @@ >>>> channel_layout = enc->channel_layout; >>>> audio_channels = enc->channels; >>>> audio_sample_rate = enc->sample_rate; >>>> + audio_bit_rate = enc->bit_rate; >>>> audio_sample_fmt = enc->sample_fmt; >>>> input_codecs[nb_icodecs++] = >>>> avcodec_find_decoder_by_name(audio_codec_name); >>>> if(audio_disable) >>>> @@ -3211,6 +3216,7 @@ >>>> } >>>> nb_ocodecs++; >>>> audio_enc->sample_rate = audio_sample_rate; >>>> + audio_enc->bit_rate = audio_bit_rate; >>>> audio_enc->time_base= (AVRational){1, audio_sample_rate}; >>>> if (audio_language) { >>>> av_metadata_set(&st->metadata, "language", audio_language); >>> >>>> Index: libavformat/avformat.h >>>> =================================================================== >>>> --- libavformat/avformat.h (revision 18096) >>>> +++ libavformat/avformat.h (working copy) >>>> @@ -261,6 +261,7 @@ >>>> enum CodecID video_codec_id; >>>> enum CodecID audio_codec_id; >>>> #endif >>>> + int bit_rate; >>>> } AVFormatParameters; >>>> >>>> //! Demuxer will use url_fopen, no opened file should be provided by the >>>> caller. >>> >>> the whole struct is pretty much deprecated and iam not happy if people >>> add new things to it. >> >> any hint on to "do it the right way" ? > > AVFormatContext.bit_rate maybe but i am not sure if this might cause some > issues > actually a much simpler solution would be to change the -ab options to set in the AVCodecContext.bitrate for decoder too like in the patch attached but it would change the behavior of ffmpeg but that's exactly what is needed, to be able to give the g722 decoder a bit_rate would that be acceptable? Kenan

7 46

[PATCH] libspeex Speex encoding
by justin.ruggles＠gmail.com 08 Sep '10

08 Sep '10

Hi, This patch combines parts of my previous libspeex encoding patch with parts of the one sent by Art Clarke. The rate control is not as intuitive to use as I would like, but it works. libspeex has the option to have the library choose a CBR bitrate based on a quality setting. Providing that option doesn't really fit well into our current system since there is no way to tell if the user is specifying CBR quality or VBR quality. So instead it just uses bitrate for CBR and quality for VBR like our other audio encoders. The default bitrate of 64kbps is higher than the maximum Speex bitrate, so at least it will be good quality by default. Thanks, Justin

6 20

dvdsub encoder: respect palette when it makes sense
by nicolas.george＠normalesup.org 05 Sep '10

05 Sep '10

Hi. The current version of the dvdsub encoder uses the alpha channel of the palette to weight the most important colors, and then completely ignores the palette. In particular, the alpha values it puts in the stream are hardcoded arbitrary values. The attached patch fix that to a certain extent: when there is exactly one rectangle and the palette has exactly 4 colors, the colors are kept in their original order and the alpha channel of the palette is copied to the stream. With this patch, it becomes possible to use the dvdsub encoder to produce a VOBSUB pair of file that mplayer can understand. Regards, -- Nicolas George

2 11

[PATCH] MMX2/SSSE3 VC1 loop filter
by lessen42＠gmail.com 11 Jul '10

11 Jul '10

Hi, Overall 17% faster decode on my Penryn, including the first function to use SSE4 instructions in ffmpeg! (which shave an entire 2 clocks off of vc1_h_loop_filter8 for me) One thing I don't understand is why the PSIGNW_SRA_MMX macro is necessary for correct results. I know that psignw isn't equivalent to ((a ^ b) - b), but the only difference I'm aware of is when b is 0, psignw sets a to 0 as well. It's probably a stupidly simple case that I'm missing... 700 dezicycles in vc1_v_loop_filter4_mmx2, 1048506 runs, 70 skips. 639 dezicycles in vc1_v_loop_filter4_ssse3, 1048447 runs, 129 skips 977 dezicycles in vc1_h_loop_filter4_mmx2, 2097069 runs, 83 skips. 951 dezicycles in vc1_h_loop_filter4_ssse3, 2097040 runs, 112 skips 1116 dezicycles in vc1_v_loop_filter8_mmx2, 33552803 runs, 1629 skips 677 dezicycles in vc1_v_loop_filter8_ssse3, 33552817 runs, 1615 skips 1648 dezicycles in vc1_h_loop_filter8_mmx2, 33552806 runs, 1626 skips 1158 dezicycles in vc1_h_loop_filter8_ssse3, 33552878 runs, 1554 skips 1137 dezicycles in vc1_h_loop_filter8_sse4, 33553447 runs, 985 skips

7 21

[PATCH] Suppress some error messages while there are previous images yet
by rnissl＠gmx.de 05 Jul '10

05 Jul '10

Hi, when showing the samples contained in subdirectory rnissl, a bunch of error messages appears which seem to be legal as those still images are no IDR frames / fields. The attached patch suppresses these error messages as long as there hasn't been any previous image yet. Bye. -- Dipl.-Inform. (FH) Reinhard Nissl mailto:rnissl at gmx.de

2 1

[PATCH] Altivec split-radix FFT
by lorenm＠u.washington.edu 01 Jul '10

01 Jul '10

1.6x faster than altivec radix-2 as measured by fft-test on a G4. 2.0x as measured by gprof. I failed to get oprofile or POWERPC_PERF to measure anything. This is my first time writing ppc asm, so any optimization hints are appreciated. I used raw asm rather than intrinsics because gcc adds a ginormous overhead to each function call. Is there anything I need to do to make it work on ppc64, if it doesn't already? --Loren Merritt

10 43

[PATCH 1/6] flacdec: change variable-length array to fixed length
by mans＠mansr.com 30 Jun '10

30 Jun '10

pred_order can never exceed 64, so always allocating that amount is safe and not very wasteful. --- libavcodec/flacdec.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/flacdec.c b/libavcodec/flacdec.c index 4ff7fae..643ed24 100644 --- a/libavcodec/flacdec.c +++ b/libavcodec/flacdec.c @@ -358,7 +358,7 @@ static int decode_subframe_lpc(FLACContext *s, int channel, int pred_order) { int i, j; int coeff_prec, qlevel; - int coeffs[pred_order]; + int coeffs[64]; int32_t *decoded = s->decoded[channel]; /* warm up samples */ -- 1.6.4

5 24

[PATCH] Default to using libraries when enabled
by lessen42＠gmail.com 25 Jun '10

25 Jun '10

Hi, This changes the order of initialization so that external libraries that are enabled are used by default over native codecs. My main motivation in moving these is to be able to have the ogg and mkv muxers default to encoding via libvorbis if it's enabled; currently, specifying CODEC_ID_VORBIS will use the native encoder regardless, which is much worse quality. However, this also affects faad and xvid. IMO, faad should be preferred anyway until the native decoder supports SBR, then dropped soon after. My only argument for xvid is that it's probably what users want to use when they --enable-libxvid.

11 37

IEC61937 compatible muxer
by bartek.wolowiec＠gmail.com 16 Jun '10

16 Jun '10

Hi, Here is IEC61937 compatible muxer. It can be used for sending compressed data over S/PDIF link. It's currently not very useful, but can be tested by: ./ffmpeg -y -i test_48khz.dts -acodec copy -f spdif test.spdif && ./ffmpeg -ar 48000 -f s16le -ac 2 -i test.spdif -f alsa plughw:0 -- Bartlomiej Wolowiec

7 23