December 2009 - ffmpeg-devel - lists.ffmpeg.org

libavfilter-soc update and variable frame size/pixel format
by stefano.sabatini-lala＠poste.it 30 Jan '10

30 Jan '10

Hi, since r19226/19279 ffmpeg supports variable frame size/pixel formats. I managed to update libavfilter-soc, and my current solution is to simply don't support it if libavfilter is enabled. That's because those are ones of the problem lavfi should natively manage, rather than leave the problem to the application, also I don't want to spend time on this since that will be removed anyway once it will be supported by the lavfi framework. See updating patch attached, OK to apply? Regards. -- FFmpeg = Freak Faboulous Mega Philosofic Elastic Geek

6 18

[PATCH] DV muxer: reduce audio fifo size to AVCODEC_MAX_AUDIO_FRAME_SIZE
by janne-ffmpeg＠jannau.net 29 Jan '10

29 Jan '10

Hi, after changing the fifo avaible space check to av_fifo_space, it's possible to realloc the audio fifos in the DV muxer. The default size is 100 * AVCODEC_MAX_AUDIO_FRAME_SIZE, currently 19 megabyte per stream. The short sample muxed during lavftest doesn't need to realloc the fifo from the new default size of AVCODEC_MAX_AUDIO_FRAME_SIZE. The largest realloc I've seen during testing was to 6M. Reducing the memory consumption of the DV muxer by a factor of 2 (meassured with massif). Janne DV muxer: reduce audio fifo size to AVCODEC_MAX_AUDIO_FRAME_SIZE reallocs audio fifo size up to 128 * AVCODEC_MAX_AUDIO_FRAME_SIZE if necessary --- libavformat/dvenc.c | 17 +++++++++++++++-- 1 files changed, 15 insertions(+), 2 deletions(-) diff --git a/libavformat/dvenc.c b/libavformat/dvenc.c index a385782..448ac73 100644 --- a/libavformat/dvenc.c +++ b/libavformat/dvenc.c @@ -234,6 +234,7 @@ int dv_assemble_frame(DVMuxContext *c, AVStream* st, uint8_t* data, int data_size, uint8_t** frame) { int i, reqasize; + unsigned int fifo_alloc_cap; *frame = &c->frame_buf[0]; reqasize = 4 * dv_audio_frame_size(c->sys, c->frames); @@ -251,8 +252,20 @@ int dv_assemble_frame(DVMuxContext *c, AVStream* st, for (i = 0; i < c->n_ast && st != c->ast[i]; i++); /* FIXME: we have to have more sensible approach than this one */ - if (av_fifo_space(c->audio_data[i]) < data_size) + if (av_fifo_space(c->audio_data[i]) < data_size) { + fifo_alloc_cap = av_fifo_size(c->audio_data[i]) + + av_fifo_space(c->audio_data[i]); + + if (fifo_alloc_cap > 100 * AVCODEC_MAX_AUDIO_FRAME_SIZE) { av_log(st->codec, AV_LOG_ERROR, "Can't process DV frame #%d. Insufficient video data or severe sync problem.\n", c->frames); + } else { + if (av_fifo_realloc2(c->audio_data[i], 2 * fifo_alloc_cap) < 0) + return AVERROR(ENOMEM); + + av_log(st->codec, AV_LOG_DEBUG, "Audio Fifo for audio stream " + "%d reallocated to %d bytes\n", i, 2 * fifo_alloc_cap); + } + } av_fifo_generic_write(c->audio_data[i], data, data_size, NULL); /* Let us see if we've got enough audio for one DV frame. */ @@ -337,7 +350,7 @@ DVMuxContext* dv_init_mux(AVFormatContext* s) c->start_time = (time_t)s->timestamp; for (i=0; i < c->n_ast; i++) { - if (c->ast[i] && !(c->audio_data[i]=av_fifo_alloc(100*AVCODEC_MAX_AUDIO_FRAME_SIZE))) { + if (c->ast[i] && !(c->audio_data[i]=av_fifo_alloc(AVCODEC_MAX_AUDIO_FRAME_SIZE))) { while (i > 0) { i--; av_fifo_free(c->audio_data[i]);

3 4

[PATCH][RFC] add a list of generic tag names
by wyskas＠gmail.com 29 Jan '10

29 Jan '10

Hi, attached is a patch for $subj. Suggestions for new tags/renames are welcome, it'll also probably need some attention from the grammar na^W^Wenglish experts :) year/date - the old code had 'year', but many formats support full date, so 'year' can be misleading. maybe there should be a separate 'year' tag and av_metadata_conv should be extended to automatically fill both. Anton Khirnov

5 38

[PATCH] Bink file demuxer and audio decoder
by daniel＠drv.nu 27 Jan '10

27 Jan '10

Hi, Attached are patches to add a Bink file demuxer and Bink audio decoder, plus support for Bink audio in Smacker files. First of all, I must say that the bulk of these patches is based on the previous patch by Peter Ross [1]; many thanks to him and anyone else who helped write the documentation on MultimediaWiki. I've attempted to update the documentation where I've noticed inaccuracies, but I give no guarantees that documentation matches code. :) I've tried to fix most of the problems mentioned in the previous thread, but if I have missed anything important, please point it out. The first patch is the most problematic; it implements the required DCT and RDFT functions, but for now they are just wrappers around the (incompatibly-licensed) fft4g functions the old patch was using. Hopefully someone will step up to write replacements for these. I attempted that myself, but I am no mathematician, and I ended up with a big mess and a thoroughly muddled brain trying to implement anything based on the descriptions I could find. I have only tested the Bink-in-Smacker support with files I created myself with the latest RAD Video Tools from their website (and it does work for those - samples can be found at http://drv.nu/temp/SMK/ ); if anyone has samples of this from actual games, these would be greatly appreciated. A small note on the Smacker demuxer: it was using the SMKA tag even for u8 PCM audio; this didn't seem right, and I haven't been able to find or create a file with such an audio format, so I'm not sure it exists at all. Any samples of this would be interesting too. I've tested at least a few samples from every game I have available that uses Bink, namely: - Heroes of Might and Magic 3: The files are hidden away inside .vid archives; they are the only revision 'b' (presumably "beta"?) I could find, and this format is not playable by the RAD player; none seem to have audio, unless the headers are different, so the demuxer currently doesn't support these (a trivial one-line patch of the probe function will enable it, but there's no way to test if it's actually correct for now) - Test Drive 6 (PC version): The only example I could find among my games of files with the oldest (BIKf) non-beta revision; features a music video of Fear Factory with Gary Numan performing "Cars" :) - Diablo 2: Samples I tested all work; see note below - GTA IV: some very large samples (TV stations), notably with keyframes; I haven't listened to the entire hour and a half, but the parts I checked were fine - Various other games, all of which work: C&C: Generals, L4D, Psychonauts, COD4, UT3, ... I also tested the samples at http://samples.mplayerhq.hu/game-formats/bink/ : - ATI/* has various chunks of files; appending the --append.this.to.complete.bik to the end of the un-suffixed file produces the full video, which works; the .x file is just another truncated part of the video - thps4/data002.tgr seems to be the only file in that dir that has audio, and it works - diablo2/d2xmusic.mpq does not contain any Bink files, but D2VIDEO.MPQ from the Cinematics CD does contain Bink files, and these work, as do the ones from the expansion - ActivisionLogo.bik, AnivisionLogo.bik, logo_collective.bik, logo_lucas.bik, original.bik: all work - logo_legal.bik: does not contain any audio Any samples that don't work (or reports of ones that actually work :), as well as any critiques on the patch, are quite welcome. Thanks, -- Daniel Verkamp [1] http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2008-April/045346.html

7 22

[PATCH] Document url_open()
by stefano.sabatini-lala＠poste.it 24 Jan '10

24 Jan '10

As in subject. -- FFmpeg = Frenzy & Foolish Magic Puristic Excellent Generator

2 3

[PATCH] Document url_open_protocol()
by stefano.sabatini-lala＠poste.it 24 Jan '10

24 Jan '10

Hi, as in subject. -- FFmpeg = Frightening and Forgiving Mean Pacific Erotic Guru

2 4

[RFC] rename ffpresets directory to presets
by baptiste.coudurier＠gmail.com 24 Jan '10

24 Jan '10

Hi guys, Anybody against it ? -- Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA FFmpeg maintainer http://www.ffmpeg.org

5 9

[RFC/HACK] textrel-free x86_64 fft_mmx.asm
by Reimar.Doeffinger＠gmx.de 23 Jan '10

23 Jan '10

Hello, it is rather ugly and might affect speed a bit, but it is the only remaining textrel in x86_64 FFmpeg with --enable-pic. I really wished there was a RIP-relative, register-argument call. I'm sure it can be made at least a bit less ugly, this is my first attempt at both that kind of thing and yasm.

2 6

[PATCH] 1D DCT for dsputil
by daniel＠drv.nu 20 Jan '10

20 Jan '10

Hi, In an effort to get at least some parts of the Bink patch committed, I am splitting it into separable pieces. This is a one-dimensional floating-point DCT used by Bink audio. The actual code was written by Peter Ross. The comments I myself have about this code: - Should it be using math.h cos()/sin() or some lookup table approach? - Can there be a test written? (I don't know enough about the math involved to write a sane test...) Thanks, -- Daniel Verkamp

7 16

What is missing for working AVFMT_FLAG_NONBLOCK?
by michaelni＠gmx.at 18 Jan '10

18 Jan '10

Hi AVFMT_FLAG_NONBLOCK is not enabled in ffmpeg/ffplay.c what is missing for it? capturing from several devices is likely going to work better if they dont block. And yes i know it all should be using select() but that is harder. And simple polling with non blocking demuxers should already work pretty well. is the only thing missing the code in ffmpeg.c that picks files based on the next expected timestamp? id like to set AVFMT_FLAG_NONBLOCK by default in ffmpeg.c -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically faster algorithms should always be preferred if you have asymptotical amounts of data

7 35