February 2010 - ffmpeg-devel - lists.ffmpeg.org

[PATCH] libspeex Speex encoding
by justin.ruggles＠gmail.com 08 Sep '10

08 Sep '10

Hi, This patch combines parts of my previous libspeex encoding patch with parts of the one sent by Art Clarke. The rate control is not as intuitive to use as I would like, but it works. libspeex has the option to have the library choose a CBR bitrate based on a quality setting. Providing that option doesn't really fit well into our current system since there is no way to tell if the user is specifying CBR quality or VBR quality. So instead it just uses bitrate for CBR and quality for VBR like our other audio encoders. The default bitrate of 64kbps is higher than the maximum Speex bitrate, so at least it will be good quality by default. Thanks, Justin

6 20

dvdsub encoder: respect palette when it makes sense
by nicolas.george＠normalesup.org 05 Sep '10

05 Sep '10

Hi. The current version of the dvdsub encoder uses the alpha channel of the palette to weight the most important colors, and then completely ignores the palette. In particular, the alpha values it puts in the stream are hardcoded arbitrary values. The attached patch fix that to a certain extent: when there is exactly one rectangle and the palette has exactly 4 colors, the colors are kept in their original order and the alpha channel of the palette is copied to the stream. With this patch, it becomes possible to use the dvdsub encoder to produce a VOBSUB pair of file that mplayer can understand. Regards, -- Nicolas George

2 11

[PATCH] check for udp_set_remote_url error
by Reimar.Doeffinger＠gmx.de 28 Jul '10

28 Jul '10

Hello, this should fix bug #1784 Index: libavformat/udp.c =================================================================== --- libavformat/udp.c (revision 22094) +++ libavformat/udp.c (working copy) @@ -356,7 +357,8 @@ if (flags & URL_WRONLY) goto fail; } else { - udp_set_remote_url(h, uri); + if (udp_set_remote_url(h, uri) < 0) + goto fail; } if (s->is_multicast && !(h->flags & URL_WRONLY))

4 3

[PATCH] Remove imgconvert.c:avg_bits_per_pixel()
by stefano.sabatini-lala＠poste.it 24 Jul '10

24 Jul '10

Hi, as in subject. Follows the difference between the avg_bits_per_pixel() and av_get_bits_per_pixel() (the second value comes from av_get_bits_per_pixel(), which is also right). bgr4_byte: 8 4 rgb4_byte: 8 4 yuva420p: 12 20 rgb555be: 16 15 rgb555le: 16 15 bgr555be: 16 15 bgr555le: 16 15 Regression test passed. Regards. -- FFmpeg = Fast & Frenzy Multipurpose Portable Ecumenical Ghost

2 4

[RFC] Make swscale-test perform only one convertion
by stefano.sabatini-lala＠poste.it 22 Jul '10

22 Jul '10

Hi all, this is meant to simplify the testing/debuggin work in lsws, and provide a basis for a future lswstest rule, often it happens that I need to test/debug only a particular conversion, I was using the scale lavfi filter for this but it is way easier this way. I expected the new result to be different from the old one as the random source is different, but I noted that the new result is almost always *worse* than the old one (that is the output obtained with the old swscale-test), can someone explain? Here it follows a sample of diff -u swscale.test.oldres swscale.test.newres: --- swscale.test.ref 2010-01-23 00:50:06.000000000 +0100 +++ swscale.test.ref.new 2010-01-29 01:32:51.000000000 +0100 @@ -90,19 +90,19 @@ yuv420p 96x96 -> yuyv422 96x 128 flags= 8 SSD= 0, 0, 0, 0 yuv420p 96x96 -> yuyv422 96x 128 flags=16 SSD= 0, 0, 0, 0 yuv420p 96x96 -> yuyv422 96x 128 flags=32 SSD= 0, 0, 0, 0 - yuv420p 96x96 -> yuyv422 128x 64 flags= 1 SSD= 1, 4, 6, 0 + yuv420p 96x96 -> yuyv422 128x 64 flags= 1 SSD= 1, 5, 9, 0 yuv420p 96x96 -> yuyv422 128x 64 flags= 2 SSD= 0, 0, 0, 0 yuv420p 96x96 -> yuyv422 128x 64 flags= 4 SSD= 0, 0, 0, 0 yuv420p 96x96 -> yuyv422 128x 64 flags= 8 SSD= 0, 1, 1, 0 yuv420p 96x96 -> yuyv422 128x 64 flags=16 SSD= 6, 0, 0, 0 yuv420p 96x96 -> yuyv422 128x 64 flags=32 SSD= 0, 1, 1, 0 - yuv420p 96x96 -> yuyv422 128x 96 flags= 1 SSD= 2, 8, 12, 0 + yuv420p 96x96 -> yuyv422 128x 96 flags= 1 SSD= 2, 9, 12, 0 yuv420p 96x96 -> yuyv422 128x 96 flags= 2 SSD= 0, 5, 3, 0 yuv420p 96x96 -> yuyv422 128x 96 flags= 4 SSD= 0, 0, 0, 0 yuv420p 96x96 -> yuyv422 128x 96 flags= 8 SSD= 0, 5, 3, 0 yuv420p 96x96 -> yuyv422 128x 96 flags=16 SSD= 0, 0, 0, 0 yuv420p 96x96 -> yuyv422 128x 96 flags=32 SSD= 0, 5, 4, 0 - yuv420p 96x96 -> yuyv422 128x 128 flags= 1 SSD= 1, 6, 9, 0 + yuv420p 96x96 -> yuyv422 128x 128 flags= 1 SSD= 1, 5, 9, 0 yuv420p 96x96 -> yuyv422 128x 128 flags= 2 SSD= 0, 1, 1, 0 yuv420p 96x96 -> yuyv422 128x 128 flags= 4 SSD= 0, 0, 0, 0 yuv420p 96x96 -> yuyv422 128x 128 flags= 8 SSD= 0, 1, 1, 0 @@ -145,19 +145,19 @@ yuv420p 96x96 -> rgb24 96x 128 flags= 8 SSD= 3, 0, 1, 0 yuv420p 96x96 -> rgb24 96x 128 flags=16 SSD= 1, 0, 0, 0 yuv420p 96x96 -> rgb24 96x 128 flags=32 SSD= 3, 0, 0, 0 - yuv420p 96x96 -> rgb24 128x 64 flags= 1 SSD= 4, 2, 5, 0 + yuv420p 96x96 -> rgb24 128x 64 flags= 1 SSD= 4, 3, 8, 0 yuv420p 96x96 -> rgb24 128x 64 flags= 2 SSD= 1, 0, 0, 0 yuv420p 96x96 -> rgb24 128x 64 flags= 4 SSD= 1, 0, 0, 0 yuv420p 96x96 -> rgb24 128x 64 flags= 8 SSD= 2, 1, 1, 0 yuv420p 96x96 -> rgb24 128x 64 flags=16 SSD= 7, 0, 0, 0 yuv420p 96x96 -> rgb24 128x 64 flags=32 SSD= 3, 1, 1, 0 - yuv420p 96x96 -> rgb24 128x 96 flags= 1 SSD= 3, 7, 10, 0 + yuv420p 96x96 -> rgb24 128x 96 flags= 1 SSD= 3, 13, 12, 0 yuv420p 96x96 -> rgb24 128x 96 flags= 2 SSD= 2, 5, 3, 0 yuv420p 96x96 -> rgb24 128x 96 flags= 4 SSD= 1, 0, 0, 0 yuv420p 96x96 -> rgb24 128x 96 flags= 8 SSD= 2, 5, 4, 0 yuv420p 96x96 -> rgb24 128x 96 flags=16 SSD= 1, 0, 0, 0 yuv420p 96x96 -> rgb24 128x 96 flags=32 SSD= 2, 6, 4, 0 - yuv420p 96x96 -> rgb24 128x 128 flags= 1 SSD= 4, 3, 9, 0 + yuv420p 96x96 -> rgb24 128x 128 flags= 1 SSD= 4, 5, 9, 0 yuv420p 96x96 -> rgb24 128x 128 flags= 2 SSD= 3, 1, 1, 0 yuv420p 96x96 -> rgb24 128x 128 flags= 4 SSD= 1, 0, 0, 0 yuv420p 96x96 -> rgb24 128x 128 flags= 8 SSD= 3, 1, 1, 0 @@ -200,38 +200,38 @@ yuv420p 96x96 -> bgr24 96x 128 flags= 8 SSD= 3, 0, 1, 0 yuv420p 96x96 -> bgr24 96x 128 flags=16 SSD= 1, 0, 0, 0 yuv420p 96x96 -> bgr24 96x 128 flags=32 SSD= 3, 0, 0, 0 - yuv420p 96x96 -> bgr24 128x 64 flags= 1 SSD= 4, 2, 5, 0 + yuv420p 96x96 -> bgr24 128x 64 flags= 1 SSD= 4, 3, 8, 0 yuv420p 96x96 -> bgr24 128x 64 flags= 2 SSD= 1, 0, 0, 0 yuv420p 96x96 -> bgr24 128x 64 flags= 4 SSD= 1, 0, 0, 0 yuv420p 96x96 -> bgr24 128x 64 flags= 8 SSD= 2, 1, 1, 0 yuv420p 96x96 -> bgr24 128x 64 flags=16 SSD= 7, 0, 0, 0 yuv420p 96x96 -> bgr24 128x 64 flags=32 SSD= 3, 1, 1, 0 [...] rgb24 -> yuv411p - rgb24 96x96 -> yuv411p 64x 64 flags= 1 SSD= 3, 28, 22, 0 + rgb24 96x96 -> yuv411p 64x 64 flags= 1 SSD= 16, 84, 167, 0 rgb24 96x96 -> yuv411p 64x 64 flags= 2 SSD= 2, 12, 15, 0 rgb24 96x96 -> yuv411p 64x 64 flags= 4 SSD= 1, 2, 3, 0 rgb24 96x96 -> yuv411p 64x 64 flags= 8 SSD= 2, 13, 15, 0 rgb24 96x96 -> yuv411p 64x 64 flags=16 SSD= 13, 29, 31, 0 rgb24 96x96 -> yuv411p 64x 64 flags=32 SSD= 2, 10, 13, 0 - rgb24 96x96 -> yuv411p 64x 96 flags= 1 SSD= 4, 33, 101, 0 + rgb24 96x96 -> yuv411p 64x 96 flags= 1 SSD= 11, 68, 154, 0 rgb24 96x96 -> yuv411p 64x 96 flags= 2 SSD= 1, 12, 15, 0 rgb24 96x96 -> yuv411p 64x 96 flags= 4 SSD= 1, 2, 3, 0 rgb24 96x96 -> yuv411p 64x 96 flags= 8 SSD= 2, 12, 15, 0 rgb24 96x96 -> yuv411p 64x 96 flags=16 SSD= 6, 29, 31, 0 rgb24 96x96 -> yuv411p 64x 96 flags=32 SSD= 1, 9, 12, 0 - rgb24 96x96 -> yuv411p 64x 128 flags= 1 SSD= 4, 33, 166, 0 + rgb24 96x96 -> yuv411p 64x 128 flags= 1 SSD= 8, 89, 166, 0 rgb24 96x96 -> yuv411p 64x 128 flags= 2 SSD= 1, 12, 15, 0 rgb24 96x96 -> yuv411p 64x 128 flags= 4 SSD= 1, 2, 3, 0 rgb24 96x96 -> yuv411p 64x 128 flags= 8 SSD= 2, 12, 15, 0 rgb24 96x96 -> yuv411p 64x 128 flags=16 SSD= 6, 29, 31, 0 rgb24 96x96 -> yuv411p 64x 128 flags=32 SSD= 1, 9, 12, 0 - rgb24 96x96 -> yuv411p 96x 64 flags= 1 SSD= 1, 21, 46, 0 + rgb24 96x96 -> yuv411p 96x 64 flags= 1 SSD= 1, 26, 76, 0 rgb24 96x96 -> yuv411p 96x 64 flags= 2 SSD= 1, 4, 5, 0 rgb24 96x96 -> yuv411p 96x 64 flags= 4 SSD= 1, 0, 0, 0 rgb24 96x96 -> yuv411p 96x 64 flags= 8 SSD= 2, 4, 4, 0 rgb24 96x96 -> yuv411p 96x 64 flags=16 SSD= 7, 18, 17, 0 rgb24 96x96 -> yuv411p 96x 64 flags=32 SSD= 1, 2, 3, 0 - rgb24 96x96 -> yuv411p 96x 96 flags= 1 SSD= 1, 11, 74, 0 + rgb24 96x96 -> yuv411p 96x 96 flags= 1 SSD= 1, 47, 74, 0 rgb24 96x96 -> yuv411p 96x 96 flags= 2 SSD= 1, 4, 4, 0 rgb24 96x96 -> yuv411p 96x 96 flags= 4 SSD= 1, 0, 0, 0 rgb24 96x96 -> yuv411p 96x 96 flags= 8 SSD= 1, 3, 3, 0 rgb24 96x96 -> yuv411p 96x 96 flags=16 SSD= 1, 18, 17, 0 rgb24 96x96 -> yuv411p 96x 96 flags=32 SSD= 1, 1, 2, 0 - rgb24 96x96 -> yuv411p 96x 128 flags= 1 SSD= 1, 13, 74, 0 + rgb24 96x96 -> yuv411p 96x 128 flags= 1 SSD= 1, 45, 74, 0 rgb24 96x96 -> yuv411p 96x 128 flags= 2 SSD= 1, 4, 4, 0 rgb24 96x96 -> yuv411p 96x 128 flags= 4 SSD= 1, 0, 0, 0 rgb24 96x96 -> yuv411p 96x 128 flags= 8 SSD= 1, 3, 3, 0 rgb24 96x96 -> yuv411p 96x 128 flags=16 SSD= 1, 18, 17, 0 rgb24 96x96 -> yuv411p 96x 128 flags=32 SSD= 1, 1, 2, 0 - rgb24 96x96 -> yuv411p 128x 64 flags= 1 SSD= 5, 8, 34, 0 + rgb24 96x96 -> yuv411p 128x 64 flags= 1 SSD= 5, 19, 34, 0 rgb24 96x96 -> yuv411p 128x 64 flags= 2 SSD= 1, 2, 2, 0 rgb24 96x96 -> yuv411p 128x 64 flags= 4 SSD= 1, 0, 0, 0 rgb24 96x96 -> yuv411p 128x 64 flags= 8 SSD= 2, 2, 2, 0 rgb24 96x96 -> yuv411p 128x 64 flags=16 SSD= 7, 14, 15, 0 rgb24 96x96 -> yuv411p 128x 64 flags=32 SSD= 1, 2, 2, 0 - rgb24 96x96 -> yuv411p 128x 96 flags= 1 SSD= 5, 5, 33, 0 + rgb24 96x96 -> yuv411p 128x 96 flags= 1 SSD= 5, 32, 33, 0 rgb24 96x96 -> yuv411p 128x 96 flags= 2 SSD= 1, 1, 1, 0 rgb24 96x96 -> yuv411p 128x 96 flags= 4 SSD= 1, 0, 0, 0 rgb24 96x96 -> yuv411p 128x 96 flags= 8 SSD= 1, 2, 2, 0 rgb24 96x96 -> yuv411p 128x 96 flags=16 SSD= 1, 14, 15, 0 rgb24 96x96 -> yuv411p 128x 96 flags=32 SSD= 1, 1, 1, 0 - rgb24 96x96 -> yuv411p 128x 128 flags= 1 SSD= 5, 17, 33, 0 + rgb24 96x96 -> yuv411p 128x 128 flags= 1 SSD= 5, 35, 33, 0 Also note that I don't want to hardcode the supported in/out formats in the swscale-test-all.sh script, but currently I don't know which is the best way to do that, I cannot extend avcodec_pix_fmt_string() with sws_isSupported{In,Out} since that would add a dependancy lsws <- lavc, my idea was to define a get_pix_fmt_string() in cmdutils.c. Suggestions are welcome. Regards. -- FFmpeg = Furious & Friendly Mystic Porno Esoteric Guide

4 24

[PATCH] Fix function parameters for rgb48 to YV12 functions.
by ramiro.polla＠gmail.com 19 Jul '10

19 Jul '10

$subj

7 34

[PATCH] MMX2/SSSE3 VC1 loop filter
by lessen42＠gmail.com 11 Jul '10

11 Jul '10

Hi, Overall 17% faster decode on my Penryn, including the first function to use SSE4 instructions in ffmpeg! (which shave an entire 2 clocks off of vc1_h_loop_filter8 for me) One thing I don't understand is why the PSIGNW_SRA_MMX macro is necessary for correct results. I know that psignw isn't equivalent to ((a ^ b) - b), but the only difference I'm aware of is when b is 0, psignw sets a to 0 as well. It's probably a stupidly simple case that I'm missing... 700 dezicycles in vc1_v_loop_filter4_mmx2, 1048506 runs, 70 skips. 639 dezicycles in vc1_v_loop_filter4_ssse3, 1048447 runs, 129 skips 977 dezicycles in vc1_h_loop_filter4_mmx2, 2097069 runs, 83 skips. 951 dezicycles in vc1_h_loop_filter4_ssse3, 2097040 runs, 112 skips 1116 dezicycles in vc1_v_loop_filter8_mmx2, 33552803 runs, 1629 skips 677 dezicycles in vc1_v_loop_filter8_ssse3, 33552817 runs, 1615 skips 1648 dezicycles in vc1_h_loop_filter8_mmx2, 33552806 runs, 1626 skips 1158 dezicycles in vc1_h_loop_filter8_ssse3, 33552878 runs, 1554 skips 1137 dezicycles in vc1_h_loop_filter8_sse4, 33553447 runs, 985 skips

7 21

[PATCH] Implement pixdesctest filter
by stefano.sabatini-lala＠poste.it 07 Jul '10

07 Jul '10

Hi, this filter is useful for testing/pedagogical purposes, so I'd like to commit it even if we don't still have a test for lavfi. Regards. -- FFmpeg = Friendly and Fiendish Majestic Picky Elaborated Guru

4 19

[PATCH] Suppress some error messages while there are previous images yet
by rnissl＠gmx.de 05 Jul '10

05 Jul '10

Hi, when showing the samples contained in subdirectory rnissl, a bunch of error messages appears which seem to be legal as those still images are no IDR frames / fields. The attached patch suppresses these error messages as long as there hasn't been any previous image yet. Bye. -- Dipl.-Inform. (FH) Reinhard Nissl mailto:rnissl at gmx.de

2 1

[PATCH] Altivec split-radix FFT
by lorenm＠u.washington.edu 01 Jul '10

01 Jul '10

1.6x faster than altivec radix-2 as measured by fft-test on a G4. 2.0x as measured by gprof. I failed to get oprofile or POWERPC_PERF to measure anything. This is my first time writing ppc asm, so any optimization hints are appreciated. I used raw asm rather than intrinsics because gcc adds a ginormous overhead to each function call. Is there anything I need to do to make it work on ppc64, if it doesn't already? --Loren Merritt

10 43