On Thu, Oct 15, 2009 at 08:42:54PM -0600, Nathan Caldwell wrote:
--- /dev/null +++ b/libavcodec/lagarithrac.h @@ -0,0 +1,112 @@ + +#endif /* AVCODEC_LAGARITHRAC_H */
Please use just one space, like we do everywhere else.
--- /dev/null +++ b/libavcodec/lagarith.c @@ -0,0 +1,543 @@ + +/** + * @file libavcodec/lagarith.c + * Lagarith lossless decoder + * @author Nathan Caldwell + * + */
pointless empty line
+enum LagarithFrameType { + FRAME_RAW = 1, /*!< Uncompressed */ + FRAME_U_RGB24 = 2, /*!< Unaligned RGB24 */ + FRAME_ARITH_YUY2 = 3, /*!< Arith coded YUY2 */ + FRAME_ARITH_RGB24 = 4, /*!< Arith coded RGB24 */ + FRAME_SOLID_GRAY = 5, /*!< Solid grayscale color frame */ + FRAME_SOLID_COLOR = 6, /*!< Solid non-grayscale color frame */ + FRAME_OLD_ARITH_RGB = 7, /*!< Obsolete arithmetic coded RGB (Maintained for backwards compatibility) */ + FRAME_ARITH_RGBA = 8, /*!< Arithmetic coded RGBA */ + FRAME_SOLID_RGBA = 9, /*!< Solid RGBA color frame */ + FRAME_ARITH_YV12 = 10, /*!< Arithmetic coded YV12 */ + FRAME_REDUCED_RES = 11, /*!< Reduced resolution frame */
Sometimes you say "arith coded", sometimes arithmetic coded", please use the latter everywhere. Also, there is no need to capitalize these non-sentences. You don't do it in other places.
+ int zeros; /*!< number of consecutave zero bytes encountered */
consecutIve
+ read += + lag_decode_line(l, &rac, dst + (i * stride), width, + stride, step, esc_count); + + src += + lag_decode_zero_run_line(l, dst + (i * stride), + src, width, step, esc_count);
The function calls on the next line look weird. Diego