Hi On Mon, Jul 28, 2025 at 04:12:13PM -0500, Romain Beauxis wrote:
Le dim. 27 juil. 2025 à 19:22, Michael Niedermayer <michael@niedermayer.cc> a écrit :
Hi Romain
On Wed, Jul 23, 2025 at 02:06:07PM -0500, Romain Beauxis wrote:
Le sam. 21 juin 2025 à 16:59, Michael Niedermayer <
michael@niedermayer.cc>
a écrit :
On Sat, Jun 21, 2025 at 10:45:32AM +0200, Romain Beauxis wrote:
Le dim. 15 juin 2025 à 00:57, Michael Niedermayer <michael@niedermayer.cc> a écrit :
On Wed, Jun 04, 2025 at 11:58:52AM -0500, Romain Beauxis wrote: > This is a redo of 574f634e49847e2225ee50013afebf0de03ef013
using a flat
> memory storage for the extradata. > > PR review comments addressed: > * Use flat memory bytestream > * Re-use existing xiph extradata layout > > ---
> libavcodec/vorbisdec.c | 42 ++++++++--- > libavformat/oggparsevorbis.c | 83 +++++++++++++++++++++-
patches that change both libraries at the same time are suspect
if one depends on changes in the other it needs minor API version bump and seperate patches so extension of API and use of it are properly tracked and testable
If I remember well, according to Andreas Rheinhardt there's no need for an API bump here since the patch is re-using existing extradata bitstream structures.
If there is really no API extension then the micro versions should be bumped so a user knows if the specific version he uses has teh fix. Also it may be usefull in bugreports about ogg to know if its prior or after this change
Hi Michael,
I have created a PR on code.ffmpeg.org here: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20026
Would you have a minute to have a look?
I do not have time, ive made a dumb mistake in configuring my inbox so iam about a week behind with emails without realizing it. thats on top of release, security, and other things
maybe someome else can look into this one replying here so noone waits for a review from me
Thanks for letting me know and sorry about your issues with your email inbox.
Do you have any advice on how to look for a reviewer for this path?
social media, like twitter also if it has a positive vibe then we can retweet thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too smart to engage in politics are punished by being governed by those who are dumber. -- Plato