Hi, On Dec 28, 2007 5:12 PM, Luca Abeni <lucabe72 at email.it> wrote:
It seems that the situation is more messy than I expected: 1) url_split() has been rewritten in r10605 2) the rewrite introduced a regression, by changing the behaviour of url_split() 3) r10775 claimed to fix the regression by introducing yet another different behaviour in url_split(). And this is the change that broke option parsing in rtsp.c.
Some data points: 1) Before r10605, rtsp://localhost:5454/test1-rtsp.mpg?tcp resulted in path="/test1-rtsp.mpg?tcp" 2) After r10605, the same url produced path="/test1-rtsp.mpg?tcp", so no change for this test case... 3) r10775 "fixed" something so that the result is now path="/test1-rtsp.mpg?". 4) So, I tried a different url: rtsp://localhost?tcp. The results are path="?tcp" before r10605, path="" after r10605, and path="" after r10775. Again, that commit does not seem to fix any regression.
That one (w/o the / in the URL) is supposed to be fixed, I remember testing that (we were actively working on ipv6 issues), and receiving confirmation [1] that others saw it fixed too. Did I mess up that badly? Ronald [1] http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2007-October/036849.html