29 Sep
2025
29 Sep
'25
4:46 p.m.
Hi Romain, My pleasure and thanks for contributing this change. I was just wanting to know on this line (tagged in PR comments), if there are scenarios where we may only get one of these blocks on segment change and if we need to also emit it to extradata. ``` if (priv->header && priv->comment && priv->setup) { ``` The answer may very well be no and that's fine. Besides that I am willing to approve then merge after a short couple days objections period. The maintainer listed for this file is not active, so I'm not sure there is anyone in particular we need to wait for.