Hello Martin, I opened PR as you requested: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20377 I fixed most of the comments, except the one about decrement operation instead of increment. I have done increment of loops in less conditions as you told me, but I have logic based on index of loop which requires to have increment (y loop & vb_pos check), otherwise I need to change logic in there, what I would try to avoid and keep it close to generic version in that case. For x loop I left increment as well to have the same logic as for y loop. All other comments I fixed. All the best, Georgii Zagoruiko On Sat, Aug 30, 2025, 10:55 PM Martin Storsjö <martin@martin.st> wrote:
On Sat, 30 Aug 2025, George Zaguri wrote:
You mentioned submition of patch as a PR, you mean open merge request I guess, how it works with mailing list? Do I need to update the patch in mailing list as well? Should I reflect opened PR somewhere?
Not sure what I mentioned earlier (that was probably before we set up the new Forgejo instance), but nowadays, you can sign up at https://code.ffmpeg.org, fork https://code.ffmpeg.org/FFmpeg/FFmpeg and send a PR there, and I can take another look at it. In that form you don't need to send the patches to the mailing list at all, and only interact with the review through the Forgejo tool.
// Martin