On Wed, Jul 6, 2022 at 10:10 AM Tristan Matthews <tmatth@videolan.org> wrote:
Hi,
On Sun, Jan 3, 2021 at 8:09 PM Andreas Rheinhardt < andreas.rheinhardt@gmail.com> wrote:
Jonathan Baudanza:
On Sun, Jan 3, 2021, at 3:34 PM, Andreas Rheinhardt wrote:
Lynne:
Apart from that LGTM.
+1 if the case of more than two channels has been properly tested.
I tested this by creating an (invalid) SDP file with channels set to 3. In this case, the rtp demuxer fails with the following message:
[sdp @ 0x7fe40280b800] Error creating opus extradata: Invalid data found when processing input
It might be more descriptive if we added a log warning about the channel count. WDYT?
It's ok as-is.
- Andreas
Could this land? I found another case that it fixes (specifically streamcopy + muxing a specific mkv file that was captured via RTP).
Sorry for the noise, I missed in the thread that the code in question moved from the opus decoder to the RTP parser and landed there. Best, Tristan