-----Original Message----- From: Marth64 <marth64@proxyid.net> Sent: Friday, February 7, 2025 4:58 AM To: FFmpeg development discussions and patches <ffmpeg- devel@ffmpeg.org> Cc: Michael Niedermayer <michael@niedermayer.cc>; softworkz <softworkz@hotmail.com>; Soft Works <softworkz-at- hotmail.com@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH v3 0/3] Add option to log timing
It works good.
Millions of log lines were written with it already :-)
First pass thoughts: 1- Rename `timeBuf` -> `bp_time`, in this way it follows snake case convention and conveys clearly that the parameter is an `AVBPrint`
Oops, missed that.
2- Option switch: +datetime and +time feels lighter/easier (vs. -ing)
Sure, I don't remember how I even came to the 'ing'.
3- Term color: the space after the time keeps the background of the time, which looks odd IMO with terminal emulator color schemes that show the background. Not sure if this is intentional. Let me know if you need a screenshot.
Here are two screenshots: https://gist.github.com/softworkz/f78a6a4973f804b9381fe37d5f75f9ea I suppose the lower one is what you are referring to, but in the upper one you can see that there are many lines with black background where it would probably also be odd when there's a single white space in-between. That being said, I don't really care about coloring so I'll gladly change it to whichever way is desired.
4- (Optional): how would you feel about RFC3339 representation? If machine parsing is a goal for this.
What I feel is that the T and Z letters make it just much harder to read. Why wouldn't it be machine-parsable without those letters? Thanks sw