17 Jun
2022
17 Jun
'22
9:40 a.m.
On 17.06.2022 10:41, Carotti, Elias wrote:
Hi all, any chance someone could possibly have a look at this patch, please? Thanks in advance
On Fri, 2022-06-10 at 10:11 +0000, Carotti, Elias wrote:
Hi, patch attached to add support for passing down to libx264 information about which macroblock could be eligible for being coded as P_SKIP.
NICE SRL, viale Monte Grappa 3/5, 20124 Milano, Italia, Registro delle Imprese di Milano Monza Brianza Lodi REA n. 2096882, Capitale Sociale: 10.329,14 EUR i.v., Cod. Fisc. e P.IVA 01133050052, Societa con Socio Unico
There's a stray printf in the patch. Also, what if a frame with such side data is passed to not-x264? Won't it leak the memory? From the looks if it, this entirely relies on x264 to free it.