On Sun, Oct 14, 2007 at 09:17:00PM +0200, Martin Zlomek wrote:
There is special case for deblocking top- and left-most macroblocks in the ffmpeg implementation. The problem is in the condition, which tests macroblock y-coordinate for equation to 0, and in y-coordinate of top-most macroblocks in bottom fields, where the coordinate is 1. The attached patch fixes this problem - the condition is fulfilled for top-most macroblocks in both top and bottom fields.
Decoded I-frames (fields in fact) should be equivalent to those decoded by the reference decoder now. P-frames are still different...
patching file libavcodec/h264.c Hunk #1 FAILED at 6372. Hunk #2 succeeded at 6532 (offset 35 lines). 1 out of 2 hunks FAILED -- saving rejects to file libavcodec/h264.c.rej [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong.