Tuesday 18 August 2009 01:31:58 Michael Niedermayer napisa?(a):
On Mon, Aug 17, 2009 at 11:25:56AM +0200, Bartlomiej Wolowiec wrote:
Monday 17 August 2009 02:43:53 Michael Niedermayer napisa?(a):
[..]
+ int pkt_offset; ///< Repetition period of data burst in bytes
is it just me or is the doxy unclear?
it's like number of bytes between two next data bursts (packets, which have header and burst payload (encapsuled frame)). Should i change comments, or maybe add at begining of file some explanation of terminology?
i guess both are a good idea
+ uint8_t *buffer; ///< Allocated buffer, used for swap bytes + int buffer_size; ///< Size of allocated buffer
+ /// Function, which generates codec dependent header information + int (*header_info) (AVFormatContext *s, AVPacket *pkt);
this too is a little unclear also i would add a empty line before /// ...
+} IEC958Context; +
+//TODO move to DSP
please do, we alraedy have bswap_buf there
i thought about it, but there is one little problem - dsputil_init() gets pointer to AVCodecContext... Any idea how should i use it in libavformat ?
i have a few dsputil could be split into a AVCodecContext specific context and a non specific one, the later could be shared amongth all "users".
though i guess that could be done after the patch is commited
[...]
Ok, i attach improved patch. -- Bartlomiej Wolowiec