On Wed, Dec 02, 2009 at 12:58:22PM +0200, Sergiy wrote:
splitted into 10 parts.
Part 0 - TS extension - already in SVN Part 1 - support for channel id > 64 - slightly another version is in SVN Part 2 - header compression - looks ok but IIRC there were servers that did not understand it - does the client still works with it? Part 3 - looks ok, will apply soon Part 4 - does rt->pkt_id really needs to be incremented? I suspect setting it from parameter would be better. Also it may go wrong when calls are interleaved like gen_connect(); gen_connect(); gen_create_stream(); Part 5 - moving application path to context is fine, but replacing parsing code chunk is not Part 6 - seems wrong (I heard that bandwidth packets should contain number of bytes read by server/client) Part 7 - several things mixed - I'm not against changing invoke channel but why? For swfUrl and a lot of other just we should have options, not hardcoded URL. \0xx are octal numbers, so \008 is wrong. And av_freep() checks for pointer, no need to have if() before it. Part 8 - adding new channel ID is fine (should be in separate patch though), I'll commit that part. Please resend the rest in separate threads (like [PATCH x/N] RTMP output: do something). It's easier to review that instead of stack of patches.