Le lun. 4 août 2025 à 03:21, Michael Niedermayer <michael@niedermayer.cc> a écrit :
Hi Romain
On Mon, Aug 04, 2025 at 02:11:03AM +0200, Michael Niedermayer wrote:
Hi Romain
On Sun, Aug 03, 2025 at 05:50:17PM -0500, Romain Beauxis wrote:
Le dim. 3 août 2025 à 16:36, Michael Niedermayer <michael@niedermayer.cc> a écrit : [...]
Do you have any advice on how to look for a reviewer for this
path?
social media, like twitter
also if it has a positive vibe then we can retweet
Respectfully, this does not make sense to me.
i dont have time ATM, and it seems the others also are overloaded
-> so the goal is to attract more reviewing manpower
but surely eventually someone will have time and look at it also this is not the most trivial patchset
I ve reviewed your patch on https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20026 now
Thank for your review and your time. In my previous message I did not mean to direct the whole concern to you in particular.
you ignored review comments made previously
Truly speaking, I did not understand them and/or lost track. I think that I do now and I'm glad that they'll remain on the PR history for future reference.
The patch also contained a trivial mistake: (maybe review your own code if you have time and reviewers are all busy) (also as said previously (IIRC) if reviewers are all busy, help review other peoples patches) priv->comment_size = 0; av_freep(&priv->setup); priv->comment_size = 0;
Thanks for spotting that out. I have addressed all your comments: * Added back legacy ogg vorbis frame decode headers parsing, split them into vorbis_decode_legacy_frame_headers and vorbis_decode_frame_headers for better proofreading. * Split commits into libavf and libavc * Added proper API bump. It looks like the API bump will be required before the release since libavf is already shipping with bitstream modifications on ogg/opus and ogg/flac.
Also its summer vacation time and everyone is busy
I understand that. Should the release be then pushed back to when other people are back to get more people and eyes on what's needed beforehand? Thanks, -- Romain