[PATCH] check for udp_set_remote_url error
Hello, this should fix bug #1784 Index: libavformat/udp.c =================================================================== --- libavformat/udp.c (revision 22094) +++ libavformat/udp.c (working copy) @@ -356,7 +357,8 @@ if (flags & URL_WRONLY) goto fail; } else { - udp_set_remote_url(h, uri); + if (udp_set_remote_url(h, uri) < 0) + goto fail; } if (s->is_multicast && !(h->flags & URL_WRONLY))
Reimar D?ffinger <Reimar.Doeffinger <at> gmx.de> writes:
this should fix bug #1784 Index: libavformat/udp.c =================================================================== --- libavformat/udp.c (revision 22094) +++ libavformat/udp.c (working copy) @@ -356,7 +357,8 @@ if (flags & URL_WRONLY) goto fail; } else { - udp_set_remote_url(h, uri); + if (udp_set_remote_url(h, uri) < 0) + goto fail;
Any reason this was not applied? Issue 1784 is still reproducible. Carl Eugen
Hi, On Wed, Jul 28, 2010 at 6:41 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
Reimar D?ffinger <Reimar.Doeffinger <at> gmx.de> writes:
this should fix bug #1784 Index: libavformat/udp.c =================================================================== --- libavformat/udp.c (revision 22094) +++ libavformat/udp.c (working copy) @@ -356,7 +357,8 @@ ? ? ? ? ?if (flags & URL_WRONLY) ? ? ? ? ? ? ?goto fail; ? ? ?} else { - ? ? ? ?udp_set_remote_url(h, uri); + ? ? ? ?if (udp_set_remote_url(h, uri) < 0) + ? ? ? ? ? ?goto fail;
Any reason this was not applied?
Issue 1784 is still reproducible.
UDP maintainer is AWOL. Please apply. :-). Ronald
On Sun, 28 Feb 2010, Reimar D?ffinger wrote:
Hello, this should fix bug #1784 Index: libavformat/udp.c =================================================================== --- libavformat/udp.c (revision 22094) +++ libavformat/udp.c (working copy) @@ -356,7 +357,8 @@ if (flags & URL_WRONLY) goto fail; } else { - udp_set_remote_url(h, uri); + if (udp_set_remote_url(h, uri) < 0) + goto fail; }
if (s->is_multicast && !(h->flags & URL_WRONLY))
FWIW, ok with me. // Martin
participants (4)
-
cehoyos＠ag.or.at -
martin＠martin.st -
Reimar.Doeffinger＠gmx.de -
rsbultje＠gmail.com