[PATCH]Support qclp in mov before stsd version 1, v2
Hi! Attached patch fixes the following sample as reported by Compn on irc: http://web.archive.org/web/20071027002243/http://www.americaone.org/video/im... As the original patch, it does not break samples with variable frame size like h263.mov Contrary to the original patch, this patch does not break stsd version 1 samples with bitrate < FULL. Please comment, Carl Eugen
On 6/6/13, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
Hi!
Attached patch fixes the following sample as reported by Compn on irc: http://web.archive.org/web/20071027002243/http://www.americaone.org/video/im... As the original patch, it does not break samples with variable frame size like h263.mov
That file does not have packets of variable frame size, all qcelp packets have same size of 35 bytes. Which means single packet - single audio frame, unlike clip43.. which have multiple qcelp frames of size 35 bytes in single packet.
Contrary to the original patch, this patch does not break stsd version 1 samples with bitrate < FULL.
Please comment, Carl Eugen
On Thursday 06 June 2013 01:33:21 pm Carl Eugen Hoyos wrote:
Hi!
Attached patch fixes the following sample as reported by Compn on irc: http://web.archive.org/web/20071027002243/http://www.americaone.org/video/i mages/clip43qt3-hi.mov As the original patch, it does not break samples with variable frame size like h263.mov Contrary to the original patch, this patch does not break stsd version 1 samples with bitrate < FULL.
This is not necessarily related to the stsd version, simpler patch attached. Carl Eugen
On 6/6/13, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
On Thursday 06 June 2013 01:33:21 pm Carl Eugen Hoyos wrote:
Hi!
Attached patch fixes the following sample as reported by Compn on irc: http://web.archive.org/web/20071027002243/http://www.americaone.org/video/i mages/clip43qt3-hi.mov As the original patch, it does not break samples with variable frame size like h263.mov Contrary to the original patch, this patch does not break stsd version 1 samples with bitrate < FULL.
This is not necessarily related to the stsd version, simpler patch attached.
Remux one of qcp files with qcelp into mov and try patch.
Carl Eugen
Paul B Mahol <onemda <at> gmail.com> writes:
Remux one of qcp files with qcelp into mov and try patch.
How is this problem related to this patch? Carl Eugen
On 6/6/13, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
Paul B Mahol <onemda <at> gmail.com> writes:
Remux one of qcp files with qcelp into mov and try patch.
How is this problem related to this patch?
Somebody could do that, would such file still play?
Carl Eugen
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Paul B Mahol <onemda <at> gmail.com> writes:
Remux one of qcp files with qcelp into mov and try patch.
How is this problem related to this patch?
Somebody could do that, would such file still play?
Neither with nor without the patch, and a patch that changes the mov demuxer imo can hardly affect the behaviour of the qcp demuxer and the mov muxer. Carl Eugen
On 6/6/13, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
Paul B Mahol <onemda <at> gmail.com> writes:
Remux one of qcp files with qcelp into mov and try patch.
How is this problem related to this patch?
Somebody could do that, would such file still play?
Neither with nor without the patch, and a patch that changes the mov demuxer imo can hardly affect the behaviour of the qcp demuxer and the mov muxer.
Yes, as expected. Your patch is just small band-aid on much bigger issue.
Carl Eugen
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Paul B Mahol <onemda <at> gmail.com> writes:
Remux one of qcp files with qcelp into mov and try patch.
Somebody could do that, would such file still play?
Neither with nor without the patch, and a patch that changes the mov demuxer imo can hardly affect the behaviour of the qcp demuxer and the mov muxer.
Yes, as expected. Your patch is just small band-aid on much bigger issue.
I do not understand a word but do you still object to the patch? Carl Eugen
On 6/6/13, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
Paul B Mahol <onemda <at> gmail.com> writes:
Remux one of qcp files with qcelp into mov and try patch.
Somebody could do that, would such file still play?
Neither with nor without the patch, and a patch that changes the mov demuxer imo can hardly affect the behaviour of the qcp demuxer and the mov muxer.
Yes, as expected. Your patch is just small band-aid on much bigger issue.
I do not understand a word but do you still object to the patch?
I think there is better solution: implementing CODEC_CAP_SUBFRAMES in decoder. AFAIK only qcp demuxer for no obvious reason stripts first byte that says what rate is used in next packet.
Carl Eugen
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
This is not necessarily related to the stsd version, simpler patch attached.
Ping, this is about ticket #2649. Carl Eugen
On 2/19/14, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
This is not necessarily related to the stsd version, simpler patch attached.
Ping, this is about ticket #2649.
Carl Eugen
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Patch is hack as qcelp can have packets smaller of 35 bytes.
Paul B Mahol <onemda <at> gmail.com> writes:
On 2/19/14, Carl Eugen Hoyos <cehoyos <at> ag.or.at> wrote:
Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
This is not necessarily related to the stsd version, simpler patch attached.
Patch is hack as qcelp can have packets smaller of 35 bytes.
Please provide a sample that fails with the patch applied. Carl Eugen
On 2/19/14, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
Paul B Mahol <onemda <at> gmail.com> writes:
On 2/19/14, Carl Eugen Hoyos <cehoyos <at> ag.or.at> wrote:
Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
This is not necessarily related to the stsd version, simpler patch attached.
Patch is hack as qcelp can have packets smaller of 35 bytes.
Please provide a sample that fails with the patch applied.
I do not care so you can apply it at any time.
On 02/19/2014 09:34 AM, Carl Eugen Hoyos wrote:
Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
This is not necessarily related to the stsd version, simpler patch attached.
Ping, this is about ticket #2649.
Carl, can you add a FIXME note and commit the simpler version of your patch? I think Paul's comments on this being a quick measure to get past the bug do make sense and I would like to have a deeper look at it at some point without blocking this ad-hoc fix. Bests, -- Reynaldo H. Verdejo Pinochet Sr. Multimedia Engineer, Open Source Group Samsung Research America - Silicon Valley
participants (3)
-
Carl Eugen Hoyos -
Paul B Mahol -
Reynaldo H. Verdejo Pinochet