Re: [FFmpeg-devel] Delivery Status Notification (Failure)
Hi, I know you guys are probably gearing up for GSoC. As a reminder I was doing the seeking api for GSoC 2010. This feature was not completed. Most of my energy went into getting the FLAC parser commited (and that took several months past GSoC.) I did submit some patches with the basic functionality over a few iterations, but they need a lot more work to pass review. This year I am not eligible as a student, but I'm planning to work on the seeking/index API more in may/june if no one else is doing this for GSoC (and you guys haven't already implemented it - I haven't been following so closely). Or if someone is, I would be happy to help out if they wished to continue my patches. Also please note that the most current patches are not the ones on the ml. I thought to tell you so you can plan GSoC accordingly if this info is any help, and to ask if I should in fact continue that work. I did some simple searches but found no references to indicate that someone is working on it. Michael
On Mon, Apr 04, 2011 at 02:51:25PM +0200, Michael Chinen wrote:
Hi,
I know you guys are probably gearing up for GSoC. As a reminder I was doing the seeking api for GSoC 2010. This feature was not completed. Most of my energy went into getting the FLAC parser commited (and that took several months past GSoC.) I did submit some patches with the basic functionality over a few iterations, but they need a lot more work to pass review.
This year I am not eligible as a student,
thats sad to hear
but I'm planning to work on the seeking/index API more in may/june if no one else is doing this
that would be great :)
for GSoC (and you guys haven't already implemented it - I haven't been following so closely). Or if someone is, I would be happy to help out if they wished to continue my patches. Also please note that the most current patches are not the ones on the ml.
Do you have some git tree with the changes? [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I hate to see young programmers poisoned by the kind of thinking Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
On Mon, Apr 4, 2011 at 3:27 PM, Michael Niedermayer <michaelni@gmx.at> wrote:
On Mon, Apr 04, 2011 at 02:51:25PM +0200, Michael Chinen wrote:
Hi,
I know you guys are probably gearing up for GSoC. As a reminder I was doing the seeking api for GSoC 2010. This feature was not completed. Most of my energy went into getting the FLAC parser commited (and that took several months past GSoC.) I did submit some patches with the basic functionality over a few iterations, but they need a lot more work to pass review.
This year I am not eligible as a student,
thats sad to hear
but I'm planning to work on the seeking/index API more in may/june if no one else is doing this
that would be great :)
Good to know!
for GSoC (and you guys haven't already implemented it - I haven't been following so closely). Or if someone is, I would be happy to help out if they wished to continue my patches. Also please note that the most current patches are not the ones on the ml.
Do you have some git tree with the changes?
I have my local git clone, but it is 6 months outdated, so has too many conflicts to be useful for reviewers. I'll submit some patches to the list when I start working on it again. I expect this to be the end of may/beginning of june. If for some reason someone wants to see it before then just let me know. Michael
On Mon, Apr 04, 2011 at 06:31:03PM +0200, Michael Chinen wrote:
On Mon, Apr 4, 2011 at 3:27 PM, Michael Niedermayer <michaelni@gmx.at> wrote:
On Mon, Apr 04, 2011 at 02:51:25PM +0200, Michael Chinen wrote:
Hi,
I know you guys are probably gearing up for GSoC. As a reminder I was doing the seeking api for GSoC 2010. This feature was not completed. Most of my energy went into getting the FLAC parser commited (and that took several months past GSoC.) I did submit some patches with the basic functionality over a few iterations, but they need a lot more work to pass review.
This year I am not eligible as a student,
thats sad to hear
but I'm planning to work on the seeking/index API more in may/june if no one else is doing this
that would be great :)
Good to know!
for GSoC (and you guys haven't already implemented it - I haven't been following so closely). Or if someone is, I would be happy to help out if they wished to continue my patches. Also please note that the most current patches are not the ones on the ml.
Do you have some git tree with the changes?
I have my local git clone, but it is 6 months outdated, so has too many conflicts to be useful for reviewers.
I'll submit some patches to the list when I start working on it again. I expect this to be the end of may/beginning of june. If for some reason someone wants to see it before then just let me know.
ping, its already september :) [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB There will always be a question for which you do not know the correct awnser.
On Mon, Apr 4, 2011 at 5:51 AM, Michael Chinen <mchinen@gmail.com> wrote:
This year I am not eligible as a student, but I'm planning to work on the seeking/index API more in may/june if no one else is doing this for GSoC (and you guys haven't already implemented it - I haven't been following so closely). Or if someone is, I would be happy to help out if they wished to continue my patches.
This is great, since the threaded H.264 seeking problem is holding back a project I'm working on. I've updated my page on this with some more info and a link to an example program and video clip: http://rarevision.com/ffmpeg-mt/ Michael N., I noticed that the problem persists with the latest git of both ffmpeg and ffmpeg-mt. However, it does not affect Libav since I guess they haven't merged ffmpeg-mt yet. Also, you were asking about sample code. I updated the page above with a link, in case you're interested in taking a look. They way I've been testing is to link with ffmpeg (mt-enabled) libs, test, and then link with libav libs since there's no "non-mt" ffmpeg anymore. The problem should be obvious after doing that.
On Mon, Apr 04, 2011 at 04:08:22PM -0700, Thomas Worth wrote:
On Mon, Apr 4, 2011 at 5:51 AM, Michael Chinen <mchinen@gmail.com> wrote:
This year I am not eligible as a student, but I'm planning to work on the seeking/index API more in may/june if no one else is doing this for GSoC (and you guys haven't already implemented it - I haven't been following so closely). Or if someone is, I would be happy to help out if they wished to continue my patches.
This is great, since the threaded H.264 seeking problem is holding back a project I'm working on. I've updated my page on this with some more info and a link to an example program and video clip:
http://rarevision.com/ffmpeg-mt/
Michael N., I noticed that the problem persists with the latest git of both ffmpeg and ffmpeg-mt. However, it does not affect Libav since I guess they haven't merged ffmpeg-mt yet. Also, you were asking about sample code. I updated the page above with a link, in case you're interested in taking a look. They way I've been testing is to link with ffmpeg (mt-enabled) libs, test, and then link with libav libs since there's no "non-mt" ffmpeg anymore. The problem should be obvious after doing that.
Seeking is not the problem, the problem is that obviously the reference picture is missing, but for some reason also h->default_ref_list[list][0].data[0] is NULL in ff_h264_decode_ref_pic_list_reordering. I wonder a bit if it might have something to do with the "//FIXME mt gives valgrind warnings and crashes if this is uncommented" I think it was a really crappy idea to merge that as is, at least these kind of changes should be under an if so that at the very least the single-threaded case is not affected.
On Tue, Apr 05, 2011 at 08:02:54PM +0200, Reimar Döffinger wrote: [...]
"//FIXME mt gives valgrind warnings and crashes if this is uncommented" I think it was a really crappy idea to merge that as is, at least these kind of changes should be under an if so that at the very least the single-threaded case is not affected.
why am i surrounded by "ohh god, my eyes are bleeding" people ;) anyway ive fixed that fixme [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I am the wisest man alive, for I know one thing, and that is that I know nothing. -- Socrates
On Wed, Apr 06, 2011 at 01:42:41AM +0200, Michael Niedermayer wrote:
On Tue, Apr 05, 2011 at 08:02:54PM +0200, Reimar Döffinger wrote: [...]
"//FIXME mt gives valgrind warnings and crashes if this is uncommented" I think it was a really crappy idea to merge that as is, at least these kind of changes should be under an if so that at the very least the single-threaded case is not affected.
why am i surrounded by "ohh god, my eyes are bleeding" people ;)
It's not about my eyes, it's about regression testing working really badly.
anyway ive fixed that fixme
Then I still have no idea why and since when that missing reference for some of these frames causes decoding to be aborted instead of concealment being run.
On Tue, Apr 5, 2011 at 11:02 AM, Reimar Döffinger <Reimar.Doeffinger@gmx.de> wrote:
On Mon, Apr 04, 2011 at 04:08:22PM -0700, Thomas Worth wrote:
On Mon, Apr 4, 2011 at 5:51 AM, Michael Chinen <mchinen@gmail.com> wrote:
This year I am not eligible as a student, but I'm planning to work on the seeking/index API more in may/june if no one else is doing this for GSoC (and you guys haven't already implemented it - I haven't been following so closely). Or if someone is, I would be happy to help out if they wished to continue my patches.
This is great, since the threaded H.264 seeking problem is holding back a project I'm working on. I've updated my page on this with some more info and a link to an example program and video clip:
http://rarevision.com/ffmpeg-mt/
Michael N., I noticed that the problem persists with the latest git of both ffmpeg and ffmpeg-mt. However, it does not affect Libav since I guess they haven't merged ffmpeg-mt yet. Also, you were asking about sample code. I updated the page above with a link, in case you're interested in taking a look. They way I've been testing is to link with ffmpeg (mt-enabled) libs, test, and then link with libav libs since there's no "non-mt" ffmpeg anymore. The problem should be obvious after doing that.
Seeking is not the problem, the problem is that obviously the reference picture is missing, but for some reason also h->default_ref_list[list][0].data[0] is NULL in ff_h264_decode_ref_pic_list_reordering. I wonder a bit if it might have something to do with the "//FIXME mt gives valgrind warnings and crashes if this is uncommented" I think it was a really crappy idea to merge that as is, at least these kind of changes should be under an if so that at the very least the single-threaded case is not affected.
That's correct, seeking works fine -- the real problem surfaces when when seeking directly past an I-frame because supposedly the decoder can't reconstruct the frame without the I-reference (from what I gather). Is it that seeking to a specific timestamp (after an I-frame, for example), doesn't buffer the previous frame? When running a normal decode loop, are frames automatically buffered? Is avcodec_flush_buffers() responsible for clearing these same buffers? An "if" as you suggested would be a good workaround until this is fixed. In which file is the aforementioned code, by the way?
participants (4)
-
Michael Chinen -
Michael Niedermayer -
Reimar Döffinger -
Thomas Worth