[PATCH 1/2] lavfi: remove mp=ilpack filter
The filter does not work, asserts here. Signed-off-by: Paul B Mahol <onemda@gmail.com> --- doc/filters.texi | 1 - libavfilter/Makefile | 1 - libavfilter/libmpcodecs/vf_ilpack.c | 458 ------------------------------------ libavfilter/vf_mp.c | 2 - 4 files changed, 462 deletions(-) delete mode 100644 libavfilter/libmpcodecs/vf_ilpack.c Boring stuff removed.
The filter funcionality is same as interlace/tinterlace. Required flag: MP_IMGFIELD_REPEAT_FIRST is never set, and can not be set as its not exported from lavf/lavc. If ever such flag becomes available, such feature should be added to telecine filter. Signed-off-by: Paul B Mahol <onemda@gmail.com> --- doc/filters.texi | 1 - libavfilter/Makefile | 1 - libavfilter/libmpcodecs/vf_softpulldown.c | 163 ------------------------------ libavfilter/vf_mp.c | 2 - 4 files changed, 167 deletions(-) delete mode 100644 libavfilter/libmpcodecs/vf_softpulldown.c Boring stuff removed.
On 4/29/13, Paul B Mahol <onemda@gmail.com> wrote:
The filter funcionality is same as interlace/tinterlace. Required flag: MP_IMGFIELD_REPEAT_FIRST is never set, and can not be set as its not exported from lavf/lavc.
If ever such flag becomes available, such feature should be added to telecine filter.
Signed-off-by: Paul B Mahol <onemda@gmail.com> --- doc/filters.texi | 1 - libavfilter/Makefile | 1 - libavfilter/libmpcodecs/vf_softpulldown.c | 163 ------------------------------ libavfilter/vf_mp.c | 2 - 4 files changed, 167 deletions(-) delete mode 100644 libavfilter/libmpcodecs/vf_softpulldown.c
Boring stuff removed.
Gonna apply both patches soon.
On date Monday 2013-04-29 10:12:28 +0000, Paul B Mahol encoded:
The filter funcionality is same as interlace/tinterlace. Required flag: MP_IMGFIELD_REPEAT_FIRST is never set, and can not be set as its not exported from lavf/lavc.
If ever such flag becomes available, such feature should be added to telecine filter.
No objections from me. -- FFmpeg = Fiendish and Foolish Moronic Problematic Elastic Gigant
On 4/29/13, Paul B Mahol <onemda@gmail.com> wrote:
The filter funcionality is same as interlace/tinterlace. Required flag: MP_IMGFIELD_REPEAT_FIRST is never set, and can not be set as its not exported from lavf/lavc.
That flag is derivided from AVFrame->repeat_pict . I would prefer filters to be removed after they have been ported or the functionality is covered by another filter.
On 5/4/13, Ivan Kalvachev <ikalvachev@gmail.com> wrote:
On 4/29/13, Paul B Mahol <onemda@gmail.com> wrote:
The filter funcionality is same as interlace/tinterlace. Required flag: MP_IMGFIELD_REPEAT_FIRST is never set, and can not be set as its not exported from lavf/lavc.
That flag is derivided from AVFrame->repeat_pict . I would prefer filters to be removed after they have been ported or the functionality is covered by another filter.
Could you provide sample where I can see difference (with mplayer)? Without sample there is no way to make sure that implemented feature/port is actually correct/does anything useful, thus rotting code that nobody is using is still stinking around in libavfilter.
On 5/5/13, Paul B Mahol <onemda@gmail.com> wrote:
On 5/4/13, Ivan Kalvachev <ikalvachev@gmail.com> wrote:
On 4/29/13, Paul B Mahol <onemda@gmail.com> wrote:
The filter funcionality is same as interlace/tinterlace. Required flag: MP_IMGFIELD_REPEAT_FIRST is never set, and can not be set as its not exported from lavf/lavc.
That flag is derivided from AVFrame->repeat_pict . I would prefer filters to be removed after they have been ported or the functionality is covered by another filter.
Could you provide sample where I can see difference (with mplayer)?
Without sample there is no way to make sure that implemented feature/port is actually correct/does anything useful, thus rotting code that nobody is using is still stinking around in libavfilter.
The filter have even bigger problems than setting flags, and as is present in lavfi does not work properly. I will remove this filter and libmpcodecs with it in next 24 hours.
On Mon, 26 Jan 2015 17:06:55 +0000 Paul B Mahol <onemda@gmail.com> wrote:
On 5/5/13, Paul B Mahol <onemda@gmail.com> wrote:
I will remove this filter and libmpcodecs with it in next 24 hours.
OK with me. thanks to all who ported filters and trolled for the 4 years we had mplayer code in ffmpeg :) -compn
On date Monday 2015-01-26 17:06:55 +0000, Paul B Mahol encoded: [...]
The filter have even bigger problems than setting flags, and as is present in lavfi does not work properly.
I will remove this filter and libmpcodecs with it in next 24 hours.
Not OK with me. Send a patch for mp removal and wait for his maintainer to approve it as usual, no need to rush it. -- FFmpeg = Fierce and Fancy Muttering Purposeless Elfic Glue
Paul B Mahol <onemda <at> gmail.com> writes:
The filter does not work, asserts here.
Isn't the only thing missing setting the correct output pixel format? Carl Eugen
On 4/29/13, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
Paul B Mahol <onemda <at> gmail.com> writes:
The filter does not work, asserts here.
Isn't the only thing missing setting the correct output pixel format?
Science when this filter was broken, and nobody complained? Also its not needed any more as similar funcionality is already available in native filter.
Carl Eugen
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On date Monday 2013-04-29 10:29:33 +0000, Paul B Mahol encoded:
On 4/29/13, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
Paul B Mahol <onemda <at> gmail.com> writes:
The filter does not work, asserts here.
Isn't the only thing missing setting the correct output pixel format?
Science when this filter was broken, and nobody complained?
Also its not needed any more as similar funcionality is already available in native filter.
I'm not an user of the filter, so can't say even what is useful for. Can someone comment on it? Is it possible emulate it with the native filters?
From mplayer:
ilpack=mode When interlaced video is stored in YUV 4:2:0 formats, chroma interlacing does not line up properly due to vertical downsampling of the chroma channels. This filter packs the planar 4:2:0 data into YUY2 (4:2:2) format with the chroma lines in their proper locations, so that in any given scanline, the luma and chroma data both come from the same field. <mode> Select the sampling mode. 0: nearest-neighbor sampling, fast but incorrect 1: linear interpolation (default) -- FFmpeg = Fierce Forgiving Majestic Problematic Entertaining Governor
On 5/4/13, Stefano Sabatini <stefasab@gmail.com> wrote:
On date Monday 2013-04-29 10:29:33 +0000, Paul B Mahol encoded:
On 4/29/13, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
Paul B Mahol <onemda <at> gmail.com> writes:
The filter does not work, asserts here.
Isn't the only thing missing setting the correct output pixel format?
Science when this filter was broken, and nobody complained?
Also its not needed any more as similar funcionality is already available in native filter.
I'm not an user of the filter, so can't say even what is useful for. Can someone comment on it?
Is it possible emulate it with the native filters?
From mplayer:
ilpack=mode
When interlaced video is stored in YUV 4:2:0 formats, chroma interlacing does not line up properly due to vertical downsampling of the chroma channels. This filter packs the planar 4:2:0 data into YUY2 (4:2:2) format with the chroma lines in their proper locations, so that in any given scanline, the luma and chroma data both come from the same field. <mode> Select the sampling mode. 0: nearest-neighbor sampling, fast but incorrect 1: linear interpolation (default)
Filter still asserts here and so I will remove it in next 24 hours. scale filter probably can be used instead of ilpack.
-- FFmpeg = Fierce Forgiving Majestic Problematic Entertaining Governor _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On Mon, Jan 19, 2015 at 02:06:52PM +0000, Paul B Mahol wrote:
On 5/4/13, Stefano Sabatini <stefasab@gmail.com> wrote:
On date Monday 2013-04-29 10:29:33 +0000, Paul B Mahol encoded:
On 4/29/13, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
Paul B Mahol <onemda <at> gmail.com> writes:
The filter does not work, asserts here.
Isn't the only thing missing setting the correct output pixel format?
Science when this filter was broken, and nobody complained?
Also its not needed any more as similar funcionality is already available in native filter.
I'm not an user of the filter, so can't say even what is useful for. Can someone comment on it?
Is it possible emulate it with the native filters?
From mplayer:
ilpack=mode
When interlaced video is stored in YUV 4:2:0 formats, chroma interlacing does not line up properly due to vertical downsampling of the chroma channels. This filter packs the planar 4:2:0 data into YUY2 (4:2:2) format with the chroma lines in their proper locations, so that in any given scanline, the luma and chroma data both come from the same field. <mode> Select the sampling mode. 0: nearest-neighbor sampling, fast but incorrect 1: linear interpolation (default)
Filter still asserts here and so I will remove it in next 24 hours.
scale filter probably can be used instead of ilpack.
13:44:12 <@ubitux> so mmh... -vf format=yuv422p will work as expected? 13:44:27 <+kierank> with forced interlaced scaling yes 13:45:41 <@ubitux> kierank: -vf scale=interl=1,format=yuv422p ? 13:45:52 <+kierank> ubitux: i believe yes [...] I didn't test, but apparently ilpack can be dropped. -- Clément B.
participants (6)
-
Carl Eugen Hoyos -
Clément Bœsch -
compn -
Ivan Kalvachev -
Paul B Mahol -
Stefano Sabatini