[PATCH] fftools/ffmpeg_sched: do not print error code
The error codes are meaningless to users, especially the ones that do not come from standard errno codes. Signed-off-by: Nicolas George <george@nsup.org> --- fftools/ffmpeg_sched.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_sched.c b/fftools/ffmpeg_sched.c index 3180367576..ba9708b65b 100644 --- a/fftools/ffmpeg_sched.c +++ b/fftools/ffmpeg_sched.c @@ -2534,7 +2534,7 @@ static void *task_wrapper(void *arg) ret = task->func(task->func_arg); if (ret < 0) av_log(task->func_arg, AV_LOG_ERROR, - "Task finished with error code: %d (%s)\n", ret, av_err2str(ret)); + "Task finished with error: %s\n", av_err2str(ret)); err = task_cleanup(sch, task->node); ret = err_merge(ret, err); @@ -2549,9 +2549,12 @@ static void *task_wrapper(void *arg) pthread_mutex_unlock(&sch->finish_lock); } - av_log(task->func_arg, ret < 0 ? AV_LOG_ERROR : AV_LOG_VERBOSE, - "Terminating thread with return code %d (%s)\n", ret, - ret < 0 ? av_err2str(ret) : "success"); + if (ret < 0) + av_log(task->func_arg, AV_LOG_ERROR, + "Terminating thread with error: %s\n", av_err2str(ret)); + else + av_log(task->func_arg, AV_LOG_VERBOSE, + "Terminating thread with success\n"); return (void*)(intptr_t)ret; } -- 2.47.2
Nicolas George (HE12025-08-03):
The error codes are meaningless to users, especially the ones that do not come from standard errno codes.
Signed-off-by: Nicolas George <george@nsup.org> --- fftools/ffmpeg_sched.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
Pushed. Regards, -- Nicolas George
On 7/27/2026 9:03 AM, Nicolas George via ffmpeg-devel wrote:
Nicolas George (HE12025-08-03):
The error codes are meaningless to users, especially the ones that do not come from standard errno codes.
Signed-off-by: Nicolas George <george@nsup.org> --- fftools/ffmpeg_sched.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
Pushed.
Regards,
Commit cd9d265344b1 'Revert "avfilter/avfiltergraph: always retry format negotiation after auto-filters"' broke FATE. Did you send that patch to the ML or made a PR for it and the other five commits?
James Almer via ffmpeg-devel (HE12026-07-27):
Commit cd9d265344b1 'Revert "avfilter/avfiltergraph: always retry format negotiation after auto-filters"' broke FATE.
Did you send that patch to the ML or made a PR for it and the other five commits?
Yes, I sent it a long time ago, and it was noticed. -- Nicolas George
participants (2)
-
James Almer -
Nicolas George