Yamaha SMAF 'CNTI' chunk is wrong.
Hi, ffmpeg developers, For Yamaha SMAF, Contents Info chunk ('CNTI') includes only following members: - Contents Class - Contents Type - Contents Code Type - Copy Status - Copy Counts (see http://smaf-yamaha.com/what/s52.html) But, in the current ffmpeg, 'CNTI' includes metadata ("VN:libavcodec,"). According to SMAF Specifications Optional Data Chunk (http://smaf-yamaha.com/what/s52.html), I corrected that metadata include Optional Data Chunk ('OPDA'). Regards, uchan
On Wed, Jun 24, 2009 at 06:39:21PM +0900, ???? wrote:
Hi, ffmpeg developers,
For Yamaha SMAF, Contents Info chunk ('CNTI') includes only following members: - Contents Class - Contents Type - Contents Code Type - Copy Status - Copy Counts
(see http://smaf-yamaha.com/what/s52.html)
But, in the current ffmpeg, 'CNTI' includes metadata ("VN:libavcodec,").
According to SMAF Specifications Optional Data Chunk (http://smaf-yamaha.com/what/s52.html), I corrected that metadata include Optional Data Chunk ('OPDA').
Regards,
uchan
mmf.c | 2 ++ 1 file changed, 2 insertions(+) 37fd3e4e1cdc4068d94570e23672a39bce804ca2 ffmpeg_mmf.patch
ok assuming it doesnt break regression tests and has been tested besides that we should store LIBAVFORMAT_IDENT when CODEC_FLAG_BITEXACT is not set, not "libavcodec" (patch for that would be welcome if some volunteer wants) [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible, but not simpler. -- Albert Einstein
Michael Niedermayer <michaelni <at> gmx.at> writes:
mmf.c | 2 ++ 1 file changed, 2 insertions(+) 37fd3e4e1cdc4068d94570e23672a39bce804ca2 ffmpeg_mmf.patch
ok assuming it doesnt break regression tests and has been tested
It does break regression tests and I have no idea how to test the patch. Carl Eugen
Michael Niedermayer <michaelni <at> gmx.at> writes:
besides that we should store LIBAVFORMAT_IDENT when CODEC_FLAG_BITEXACT is not set, not "libavcodec" (patch for that would be welcome if some volunteer wants)
I committed such a change. Carl Eugen
On 1/5/13, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
Michael Niedermayer <michaelni <at> gmx.at> writes:
besides that we should store LIBAVFORMAT_IDENT when CODEC_FLAG_BITEXACT is not set, not "libavcodec" (patch for that would be welcome if some volunteer wants)
I committed such a change.
So it took 6 years to finally fix this :depressed
内田佳久 <yoshihisa.uchida <at> gmail.com> writes:
For Yamaha SMAF, Contents Info chunk ('CNTI') includes only following members: - Contents Class - Contents Type - Contents Code Type - Copy Status - Copy Counts
(see http://smaf-yamaha.com/what/s52.html)
But, in the current ffmpeg, 'CNTI' includes metadata ("VN:libavcodec,").
According to SMAF Specifications Optional Data Chunk (http://smaf-yamaha.com/what/s52.html),
Should be: http://smaf-yamaha.com/what/s53.html
I corrected that metadata include Optional Data Chunk ('OPDA').
I applied this patch after reading the specification and old mailing list threads that claim that the files have never played on real hardware. Carl Eugen
participants (5)
-
Carl Eugen Hoyos -
cehoyos@ag.or.at -
michaelni@gmx.at -
Paul B Mahol -
yoshihisa.uchida@gmail.com